2019-06-29 10:20:13

by Hariprasad Kelam

Subject: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch

CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 4a4d17b..b9d13e3 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -230,7 +230,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe)
/* pwlanhdr = (struct rtw_ieee80211_hdr *)pframe; */
/* memcpy(pmgntframe->attrib.ra, pwlanhdr->addr1, ETH_ALEN); */

- if (padapter->securitypriv.binstallBIPkey == true) {
+ if (padapter->securitypriv.binstallBIPkey) {
if (IS_MCAST(pmgntframe->attrib.ra)) {
pmgntframe->attrib.encrypt = _BIP_;
/* pmgntframe->attrib.bswenc = true; */
@@ -430,7 +430,7 @@ s32 rtw_hal_macid_sleep(struct adapter *padapter, u32 macid)

support = false;
rtw_hal_get_def_var(padapter, HAL_DEF_MACID_SLEEP, &support);
- if (false == support)
+ if (!support)
return _FAIL;

rtw_hal_set_hwreg(padapter, HW_VAR_MACID_SLEEP, (u8 *)&macid);
@@ -445,7 +445,7 @@ s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32 macid)

support = false;
rtw_hal_get_def_var(padapter, HAL_DEF_MACID_SLEEP, &support);
- if (false == support)
+ if (!support)
return _FAIL;

rtw_hal_set_hwreg(padapter, HW_VAR_MACID_WAKEUP, (u8 *)&macid);
--
2.7.4

2019-06-29 10:34:22

by Dan Carpenter

Subject: Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

You sent 10 patches with the same subject.

Btw, I can't recall ever seeing a bug caused by a true false comparison.
I agree on style principles with the checkpatch warning, but I do
think it over states the risk (which is as far as I can see is zero).

regards,
dan carpenter

2019-07-01 07:49:38

by Greg Kroah-Hartman

Subject: Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

On Sat, Jun 29, 2019 at 03:49:09PM +0530, Hariprasad Kelam wrote:
> fix below issues reported by checkpatch
>
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

As Dan said, you sent 10 patches with the same subject, so I can't take
these.

Also, please properly "thread" the patches so they show up linked to
each other. git send-email will do this automatically for you if you
use it (and you should) for multiple emails.

thanks,

greg k-h