2019-07-05 12:14:59

by Maxime Chevallier

Subject: [PATCH net-next 0/2] net: mvpp2: Add classification based on the ETHER flow

Hello everyone,

This series adds support for classification of the ETHER flow in the
mvpp2 driver.

The first patch allows detecting when a user specifies a flow_type that
isn't supported by the driver, while the second adds support for this
flow_type by adding the mapping between the ETHER_FLOW enum value and
the relevant classifier flow entries.

Thanks,

Maxime

Maxime Chevallier (2):
net: mvpp2: cls: Report an error for unsupported flow types
net: mvpp2: cls: Add support for ETHER_FLOW

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 6 ++++++
1 file changed, 6 insertions(+)

--
2.20.1

2019-07-05 12:14:59

by Maxime Chevallier

Subject: [PATCH net-next 1/2] net: mvpp2: cls: Report an error for unsupported flow types

Add a missing check to detect flow types that we don't support, so that
user can be informed of this.

Signed-off-by: Maxime Chevallier <[email protected]>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index b195fb5d61f4..6c088c903c15 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -1373,6 +1373,10 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port,

efs->rule.flow = ethtool_rule->rule;
efs->rule.flow_type = mvpp2_cls_ethtool_flow_to_type(info->fs.flow_type);
+ if (efs->rule.flow_type < 0) {
+ ret = efs->rule.flow_type;
+ goto clean_rule;
+ }

ret = mvpp2_cls_rfs_parse_rule(&efs->rule);
if (ret)
--
2.20.1

2019-07-05 22:14:42

by Jakub Kicinski

Subject: Re: [PATCH net-next 0/2] net: mvpp2: Add classification based on the ETHER flow

On Fri, 5 Jul 2019 14:09:11 +0200, Maxime Chevallier wrote:
> Hello everyone,
>
> This series adds support for classification of the ETHER flow in the
> mvpp2 driver.
>
> The first patch allows detecting when a user specifies a flow_type that
> isn't supported by the driver, while the second adds support for this
> flow_type by adding the mapping between the ETHER_FLOW enum value and
> the relevant classifier flow entries.

LGTM

2019-07-08 23:41:42

by David Miller

Subject: Re: [PATCH net-next 0/2] net: mvpp2: Add classification based on the ETHER flow

From: Maxime Chevallier <[email protected]>
Date: Fri, 5 Jul 2019 14:09:11 +0200

> Hello everyone,
>
> This series adds support for classification of the ETHER flow in the
> mvpp2 driver.
>
> The first patch allows detecting when a user specifies a flow_type that
> isn't supported by the driver, while the second adds support for this
> flow_type by adding the mapping between the ETHER_FLOW enum value and
> the relevant classifier flow entries.

Series applied, thanks.