2019-07-23 23:23:42

by Weitao Hou

Subject: [PATCH] mm/hotplug: remove unneeded return for void function

return is unneeded in void function

Signed-off-by: Weitao Hou <[email protected]>
---
mm/memory_hotplug.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 2a9bbddb0e55..c73f09913165 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
return;
release_resource(res);
kfree(res);
- return;
}

#ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
@@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
arch_refresh_nodedata(nid, NULL);
free_percpu(pgdat->per_cpu_nodestats);
arch_free_nodedata(pgdat);
- return;
}


--
2.18.0

2019-07-23 23:24:59

by David Hildenbrand

Subject: Re: [PATCH] mm/hotplug: remove unneeded return for void function

On 23.07.19 15:08, Weitao Hou wrote:
> return is unneeded in void function
>
> Signed-off-by: Weitao Hou <[email protected]>
> ---
> mm/memory_hotplug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
> return;
> release_resource(res);
> kfree(res);
> - return;
> }
>
> #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
> arch_refresh_nodedata(nid, NULL);
> free_percpu(pgdat->per_cpu_nodestats);
> arch_free_nodedata(pgdat);
> - return;
> }
>
>
>

Reviewed-by: David Hildenbrand <[email protected]>

--

Thanks,

David / dhildenb

2019-07-23 23:25:24

by Oscar Salvador

Subject: Re: [PATCH] mm/hotplug: remove unneeded return for void function

On Tue, Jul 23, 2019 at 09:08:14PM +0800, Weitao Hou wrote:
> return is unneeded in void function
>
> Signed-off-by: Weitao Hou <[email protected]>

Reviewed-by: Oscar Salvador <[email protected]>

> ---
> mm/memory_hotplug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
> return;
> release_resource(res);
> kfree(res);
> - return;
> }
>
> #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
> arch_refresh_nodedata(nid, NULL);
> free_percpu(pgdat->per_cpu_nodestats);
> arch_free_nodedata(pgdat);
> - return;
> }
>
>
> --
> 2.18.0
>

--
Oscar Salvador
SUSE L3