2019-07-30 12:38:34

by Jason Gunthorpe

Subject: Re: [PATCH 03/13] nouveau: pass struct nouveau_svmm to nouveau_range_fault

On Tue, Jul 30, 2019 at 08:51:53AM +0300, Christoph Hellwig wrote:
> This avoid having to abuse the vma field in struct hmm_range to unlock
> the mmap_sem.

I think the change inside hmm_range_fault got lost on rebase, it is
now using:

up_read(&range->hmm->mm->mmap_sem);

But, yes, lets change it to use svmm->mm and try to keep struct hmm
opaque to drivers

Jason

2019-07-30 17:44:53

by Christoph Hellwig

Subject: Re: [PATCH 03/13] nouveau: pass struct nouveau_svmm to nouveau_range_fault

On Tue, Jul 30, 2019 at 12:35:59PM +0000, Jason Gunthorpe wrote:
> On Tue, Jul 30, 2019 at 08:51:53AM +0300, Christoph Hellwig wrote:
> > This avoid having to abuse the vma field in struct hmm_range to unlock
> > the mmap_sem.
>
> I think the change inside hmm_range_fault got lost on rebase, it is
> now using:
>
> up_read(&range->hmm->mm->mmap_sem);
>
> But, yes, lets change it to use svmm->mm and try to keep struct hmm
> opaque to drivers

It got lost somewhat intentionally as I didn't want the churn, but I
forgot to update the changelog. But if you are fine with changing it
over I can bring it back.