2019-07-30 16:38:27

by Yue Haibing

Subject: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static

Fix sparse warning:

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
symbol 'analogix_dp_atomic_check' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index c82c7d5..f2f7f69 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
}


-int analogix_dp_atomic_check(struct drm_connector *connector,
- struct drm_atomic_state *state)
+static int analogix_dp_atomic_check(struct drm_connector *connector,
+ struct drm_atomic_state *state)
{
struct analogix_dp_device *dp = to_dp(connector);
struct drm_connector_state *conn_state;
--
2.7.4

2019-07-30 18:09:10

by Sean Paul

Subject: Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static

On Tue, Jul 30, 2019 at 11:00:57PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
> symbol 'analogix_dp_atomic_check' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Thanks for your patch, applied to drm-misc-next

Sean

> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c82c7d5..f2f7f69 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
> }
>
>
> -int analogix_dp_atomic_check(struct drm_connector *connector,
> - struct drm_atomic_state *state)
> +static int analogix_dp_atomic_check(struct drm_connector *connector,
> + struct drm_atomic_state *state)
> {
> struct analogix_dp_device *dp = to_dp(connector);
> struct drm_connector_state *conn_state;
> --
> 2.7.4
>
>

--
Sean Paul, Software Engineer, Google / Chromium OS