Hi all,
After merging the crypto tree, today's linux-next build (sparc64
defconfig) failed like this:
drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
err = devm_hwrng_register(&pdev->dev, &np->hwrng);
^~~~
cdev
drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
3e75241be808 ("hwrng: drivers - Use device-managed registration API")
I applied the following patch for today:
From: Stephen Rothwell <[email protected]>
Date: Mon, 5 Aug 2019 14:49:59 +1000
Subject: [PATCH] hwrng: fix typo in n2-drv.c
Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/char/hw_random/n2-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 2d256b3470db..73e408146420 100644
--- a/drivers/char/hw_random/n2-drv.c
+++ b/drivers/char/hw_random/n2-drv.c
@@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
np->hwrng.data_read = n2rng_data_read;
np->hwrng.priv = (unsigned long) np;
- err = devm_hwrng_register(&pdev->dev, &np->hwrng);
+ err = devm_hwrng_register(&op->dev, &np->hwrng);
if (err)
goto out_hvapi_unregister;
--
2.20.1
--
Cheers,
Stephen Rothwell
On Mon, Aug 5, 2019 at 12:57 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
> err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> ^~~~
> cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
>
It is my typo, thanks for your fix!
Regards,
Chuhong
> I applied the following patch for today:
>
> From: Stephen Rothwell <[email protected]>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
>
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/char/hw_random/n2-drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
> np->hwrng.data_read = n2rng_data_read;
> np->hwrng.priv = (unsigned long) np;
>
> - err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> + err = devm_hwrng_register(&op->dev, &np->hwrng);
> if (err)
> goto out_hvapi_unregister;
>
> --
> 2.20.1
>
> --
> Cheers,
> Stephen Rothwell
Hi all,
On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
>
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
> err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> ^~~~
> cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
>
> I applied the following patch for today:
>
> From: Stephen Rothwell <[email protected]>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
>
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/char/hw_random/n2-drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
> np->hwrng.data_read = n2rng_data_read;
> np->hwrng.priv = (unsigned long) np;
>
> - err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> + err = devm_hwrng_register(&op->dev, &np->hwrng);
> if (err)
> goto out_hvapi_unregister;
>
> --
> 2.20.1
I am still applying that patch ...
--
Cheers,
Stephen Rothwell
On Thu, Aug 08, 2019 at 11:52:45AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > After merging the crypto tree, today's linux-next build (sparc64
> > defconfig) failed like this:
> >
> > drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> > drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
> > err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> > ^~~~
> > cdev
> > drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
> >
> > Caused by commit
> >
> > 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> >
> > I applied the following patch for today:
> >
> > From: Stephen Rothwell <[email protected]>
> > Date: Mon, 5 Aug 2019 14:49:59 +1000
> > Subject: [PATCH] hwrng: fix typo in n2-drv.c
> >
> > Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> > Signed-off-by: Stephen Rothwell <[email protected]>
> > ---
> > drivers/char/hw_random/n2-drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> > index 2d256b3470db..73e408146420 100644
> > --- a/drivers/char/hw_random/n2-drv.c
> > +++ b/drivers/char/hw_random/n2-drv.c
> > @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
> > np->hwrng.data_read = n2rng_data_read;
> > np->hwrng.priv = (unsigned long) np;
> >
> > - err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> > + err = devm_hwrng_register(&op->dev, &np->hwrng);
> > if (err)
> > goto out_hvapi_unregister;
> >
> > --
> > 2.20.1
>
> I am still applying that patch ...
Sorry, I forgot about your patch as it wasn't cced to the crypto
mailing list. It should be out there now.
I've also added a compile test for this driver so at least it should
fail for me on x86 too.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Herbert,
On Thu, 8 Aug 2019 13:01:57 +1000 Herbert Xu <[email protected]> wrote:
>
> Sorry, I forgot about your patch as it wasn't cced to the crypto
> mailing list. It should be out there now.
Excellent, thanks. Should I add the crypto mailing list as a contact
for problems? Mostly the emails are just reporting conflicts and only
very occasionally do I actually send a useful patch. If so, what is
its address?
> I've also added a compile test for this driver so at least it should
> fail for me on x86 too.
Even better! ;-)
--
Cheers,
Stephen Rothwell
On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
>
> Excellent, thanks. Should I add the crypto mailing list as a contact
> for problems? Mostly the emails are just reporting conflicts and only
> very occasionally do I actually send a useful patch. If so, what is
> its address?
Yes please. The address is
[email protected]
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Herbert,
On Thu, 8 Aug 2019 15:00:04 +1000 Herbert Xu <[email protected]> wrote:
>
> On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote:
> >
> > Excellent, thanks. Should I add the crypto mailing list as a contact
> > for problems? Mostly the emails are just reporting conflicts and only
> > very occasionally do I actually send a useful patch. If so, what is
> > its address?
>
> Yes please. The address is
>
> [email protected]
Done.
--
Cheers,
Stephen Rothwell