2019-08-12 09:40:58

by Ioana Ciornei

Subject: [PATCH 03/10] staging: fsl-dpaa2/ethsw: add line terminator to all formats

Add the '\n' line terminator to the string formats missing it.

Signed-off-by: Ioana Ciornei <[email protected]>
---
drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 2 +-
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
index 926a0c053e18..95e9f1096999 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
@@ -65,7 +65,7 @@ static void ethsw_get_drvinfo(struct net_device *netdev,
port_priv->idx,
&state);
if (err) {
- netdev_err(netdev, "ERROR %d getting link state", err);
+ netdev_err(netdev, "ERROR %d getting link state\n", err);
goto out;
}

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 302842c3bdfe..9ade73928e60 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -722,12 +722,12 @@ static irqreturn_t ethsw_irq0_handler_thread(int irq_num, void *arg)
err = dpsw_get_irq_status(ethsw->mc_io, 0, ethsw->dpsw_handle,
DPSW_IRQ_INDEX_IF, &status);
if (err) {
- dev_err(dev, "Can't get irq status (err %d)", err);
+ dev_err(dev, "Can't get irq status (err %d)\n", err);

err = dpsw_clear_irq_status(ethsw->mc_io, 0, ethsw->dpsw_handle,
DPSW_IRQ_INDEX_IF, 0xFFFFFFFF);
if (err)
- dev_err(dev, "Can't clear irq status (err %d)", err);
+ dev_err(dev, "Can't clear irq status (err %d)\n", err);
goto out;
}

@@ -772,21 +772,21 @@ static int ethsw_setup_irqs(struct fsl_mc_device *sw_dev)
IRQF_NO_SUSPEND | IRQF_ONESHOT,
dev_name(dev), dev);
if (err) {
- dev_err(dev, "devm_request_threaded_irq(): %d", err);
+ dev_err(dev, "devm_request_threaded_irq(): %d\n", err);
goto free_irq;
}

err = dpsw_set_irq_mask(ethsw->mc_io, 0, ethsw->dpsw_handle,
DPSW_IRQ_INDEX_IF, mask);
if (err) {
- dev_err(dev, "dpsw_set_irq_mask(): %d", err);
+ dev_err(dev, "dpsw_set_irq_mask(): %d\n", err);
goto free_devm_irq;
}

err = dpsw_set_irq_enable(ethsw->mc_io, 0, ethsw->dpsw_handle,
DPSW_IRQ_INDEX_IF, 1);
if (err) {
- dev_err(dev, "dpsw_set_irq_enable(): %d", err);
+ dev_err(dev, "dpsw_set_irq_enable(): %d\n", err);
goto free_devm_irq;
}

--
1.9.1

2019-08-12 14:45:26

by Greg Kroah-Hartman

Subject: Re: [PATCH 03/10] staging: fsl-dpaa2/ethsw: add line terminator to all formats

On Mon, Aug 12, 2019 at 12:39:11PM +0300, Ioana Ciornei wrote:
> Add the '\n' line terminator to the string formats missing it.
>
> Signed-off-by: Ioana Ciornei <[email protected]>
> ---
> drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 2 +-
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)

Are you sure none of these patches should have a "Reported-by:" tag on
them? These were all done based on a review, so someone did that
review...

Please fix up the whole series and resend.

thanks,

greg k-h

2019-08-13 07:30:42

by Ioana Ciornei

Subject: Re: [PATCH 03/10] staging: fsl-dpaa2/ethsw: add line terminator to all formats

On 8/12/19 5:44 PM, Greg KH wrote:
> On Mon, Aug 12, 2019 at 12:39:11PM +0300, Ioana Ciornei wrote:
>> Add the '\n' line terminator to the string formats missing it.
>>
>> Signed-off-by: Ioana Ciornei <[email protected]>
>> ---
>> drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 2 +-
>> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 10 +++++-----
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Are you sure none of these patches should have a "Reported-by:" tag on
> them? These were all done based on a review, so someone did that
> review...
>
> Please fix up the whole series and resend.
>
> thanks,
>
> greg k-h
>

Sure, sorry for forgetting this. Will fix up.

Ioana