2019-08-13 02:31:57

by Yue Haibing

Subject: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building

While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
not selected, it fails:

drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'

select GENERIC_IRQ_CHIP to fix this.

Reported-by: Hulk Robot <[email protected]>
Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 3c8308e..ccbb897 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -320,6 +320,7 @@ config INGENIC_TCU_IRQ
default MACH_INGENIC
depends on MIPS || COMPILE_TEST
select MFD_SYSCON
+ select GENERIC_IRQ_CHIP
help
Support for interrupts in the Timer/Counter Unit (TCU) of the Ingenic
JZ47xx SoCs.
--
2.7.4

2019-08-16 12:29:47

by Thomas Gleixner

Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building

On Tue, 13 Aug 2019, YueHaibing wrote:

> While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> not selected, it fails:
>
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
>
> select GENERIC_IRQ_CHIP to fix this.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")

git show 9536eba03ec7

fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
the working tree.

Thanks,

tglx

2019-08-16 20:20:30

by Paul Burton

Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building

Hi Thomas,

On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote:
> On Tue, 13 Aug 2019, YueHaibing wrote:
>
> > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> > not selected, it fails:
> >
> > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
> >
> > select GENERIC_IRQ_CHIP to fix this.
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
>
> git show 9536eba03ec7
>
> fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
> the working tree.

The referenced patch is in mips-next - can I get your Ack to apply this
there too?

Thanks,
Paul

2019-08-16 20:42:50

by Thomas Gleixner

Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building

On Fri, 16 Aug 2019, Paul Burton wrote:
> On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote:
> > On Tue, 13 Aug 2019, YueHaibing wrote:
> >
> > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> > > not selected, it fails:
> > >
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
> > >
> > > select GENERIC_IRQ_CHIP to fix this.
> > >
> > > Reported-by: Hulk Robot <[email protected]>
> > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> >
> > git show 9536eba03ec7
> >
> > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
> > the working tree.
>
> The referenced patch is in mips-next - can I get your Ack to apply this
> there too?

Sure. Acked-by-me :)

2019-08-19 21:19:12

by Paul Burton

Subject: Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building

Hello,

YueHaibing wrote:
> While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> not selected, it fails:
>
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
>
> select GENERIC_IRQ_CHIP to fix this.

Applied to mips-next.

> commit 8084499bd7d4
> https://git.kernel.org/mips/c/8084499bd7d4
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> Signed-off-by: YueHaibing <[email protected]>
> Acked-by: Thomas Gleixner <[email protected]>
> Signed-off-by: Paul Burton <[email protected]>

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]