2019-08-21 15:43:48

by Sylwester Nawrocki

Subject: [PATCH] soc: samsung: chipid: Remove the regmap lookup error log

In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid
driver to use the regmap API") of_find_compatible_node() call was
substituted with syscon_regmap_lookup_by_compatible() but also an error
log was added for case where lookup fails. On multiplatform the lookup
will always fail on any non-samsung device so the log is incorrect.
Remove the error log and just return an error code from
syscon_regmap_lookup_by_compatible() which internally calls
of_find_compatible_node().

Reported-by: Jon Hunter <[email protected]>
Signed-off-by: Sylwester Nawrocki <[email protected]>
---
drivers/soc/samsung/exynos-chipid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 75b6b880d9ef..c55a47cfe617 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -56,10 +56,8 @@ int __init exynos_chipid_early_init(void)
int ret;

regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid");
- if (IS_ERR(regmap)) {
- pr_err("Failed to get CHIPID regmap\n");
+ if (IS_ERR(regmap))
return PTR_ERR(regmap);
- }

ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
if (ret < 0)
--
2.17.1

2019-08-23 07:17:23

by Krzysztof Kozlowski

Subject: Re: [PATCH] soc: samsung: chipid: Remove the regmap lookup error log

On Wed, Aug 21, 2019 at 05:05:39PM +0200, Sylwester Nawrocki wrote:
> In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid
> driver to use the regmap API") of_find_compatible_node() call was
> substituted with syscon_regmap_lookup_by_compatible() but also an error
> log was added for case where lookup fails. On multiplatform the lookup
> will always fail on any non-samsung device so the log is incorrect.
> Remove the error log and just return an error code from
> syscon_regmap_lookup_by_compatible() which internally calls
> of_find_compatible_node().
>
> Reported-by: Jon Hunter <[email protected]>

Thanks, applied.

Best regards,
Krzysztof