2019-08-22 18:54:09

by James Clark

Subject: [PATCH] Fixes hang in zstd compression test by changing the source of random data.

Running 'perf test' with zstd compression linked will hang at the test
'Zstd perf.data compression/decompression' because /dev/random blocks
reads until there is enough entropy. This means that the test will
appear to never complete unless the mouse is continually moved while
running it.

Signed-off-by: James Clark <[email protected]>
---
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 899604d1..63a91ec 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -13,7 +13,7 @@ skip_if_no_z_record() {
collect_z_record() {
echo "Collecting compressed record file:"
$perf_tool record -o $trace_file -g -z -F 5000 -- \
- dd count=500 if=/dev/random of=/dev/null
+ dd count=500 if=/dev/urandom of=/dev/null
}

check_compressed_stats() {
--
2.7.4

2019-08-23 08:20:56

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.

Em Thu, Aug 22, 2019 at 06:24:07PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
> > Running 'perf test' with zstd compression linked will hang at the test
> > 'Zstd perf.data compression/decompression' because /dev/random blocks
> > reads until there is enough entropy. This means that the test will
> > appear to never complete unless the mouse is continually moved while
> > running it.
>
> message came mangled, had to do it by hand and then hook up your header
> so as to get the correct date, attribution, etc, please check
> Documentation/process/email-clients.rst,

Having said that, thanks, applied.

- Arnaldo

2019-08-23 10:02:08

by Alexey Budankov

Subject: Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.

On 22.08.2019 16:55, James Clark wrote:
> Running 'perf test' with zstd compression linked will hang at the test
> 'Zstd perf.data compression/decompression' because /dev/random blocks
> reads until there is enough entropy. This means that the test will
> appear to never complete unless the mouse is continually moved while
> running it.
>
> Signed-off-by: James Clark <[email protected]>
> ---
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 899604d1..63a91ec 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -13,7 +13,7 @@ skip_if_no_z_record() {
> collect_z_record() {
> echo "Collecting compressed record file:"
> $perf_tool record -o $trace_file -g -z -F 5000 -- \
> - dd count=500 if=/dev/random of=/dev/null
> + dd count=500 if=/dev/urandom of=/dev/null

Acked-by: Alexey Budankov <[email protected]>

~Alexey

> }
>
> check_compressed_stats() {
>

2019-08-23 13:56:30

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.

Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
> Running 'perf test' with zstd compression linked will hang at the test
> 'Zstd perf.data compression/decompression' because /dev/random blocks
> reads until there is enough entropy. This means that the test will
> appear to never complete unless the mouse is continually moved while
> running it.

message came mangled, had to do it by hand and then hook up your header
so as to get the correct date, attribution, etc, please check
Documentation/process/email-clients.rst,

- Arnaldo

> Signed-off-by: James Clark <[email protected]>
> ---
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 899604d1..63a91ec 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -13,7 +13,7 @@ skip_if_no_z_record() {
> collect_z_record() {
> echo "Collecting compressed record file:"
> $perf_tool record -o $trace_file -g -z -F 5000 -- \
> - dd count=500 if=/dev/random of=/dev/null
> + dd count=500 if=/dev/urandom of=/dev/null
> }
>
> check_compressed_stats() {
> --
> 2.7.4
>

--

- Arnaldo

2019-08-23 21:30:23

by James Clark

Subject: Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.

Sorry about that, I will look into it.

Thanks
James

On 22/08/2019 22:24, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 22, 2019 at 06:24:07PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
>>> Running 'perf test' with zstd compression linked will hang at the test
>>> 'Zstd perf.data compression/decompression' because /dev/random blocks
>>> reads until there is enough entropy. This means that the test will
>>> appear to never complete unless the mouse is continually moved while
>>> running it.
>>
>> message came mangled, had to do it by hand and then hook up your header
>> so as to get the correct date, attribution, etc, please check
>> Documentation/process/email-clients.rst,
>
> Having said that, thanks, applied.
>
> - Arnaldo
>

2019-08-27 08:30:53

by tip-bot2 for Alexey Makhalov

Subject: [tip: perf/core] perf tests: Fixes hang in zstd compression test by changing the source of random data

The following commit has been merged into the perf/core branch of tip:

Commit-ID: d93fc7ac88c7347d1c31ca158d1466d1ce2097e1
Gitweb: https://git.kernel.org/tip/d93fc7ac88c7347d1c31ca158d1466d1ce2097e1
Author: James Clark <[email protected]>
AuthorDate: Thu, 22 Aug 2019 13:55:15
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Mon, 26 Aug 2019 11:58:29 -03:00

perf tests: Fixes hang in zstd compression test by changing the source of random data

Running 'perf test' with zstd compression linked will hang at the test
'Zstd perf.data compression/decompression' because /dev/random blocks
reads until there is enough entropy. This means that the test will
appear to never complete unless the mouse is continually moved while
running it.

Signed-off-by: James Clark <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Alexey Budankov <[email protected]>
Cc: Jeremy Linton <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 899604d..63a91ec 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -13,7 +13,7 @@ skip_if_no_z_record() {
collect_z_record() {
echo "Collecting compressed record file:"
$perf_tool record -o $trace_file -g -z -F 5000 -- \
- dd count=500 if=/dev/random of=/dev/null
+ dd count=500 if=/dev/urandom of=/dev/null
}

check_compressed_stats() {