2019-09-05 07:38:40

by zhong jiang

Subject: [PATCH 0/4] Use PTR_ERR_OR_ZERO directly

With the help of ptr_ret.cocci, I find some place to use
PTR_ERR_OR_ZERO directly.

zhong jiang (4):
bus: ti-sysc: Use PTR_ERR_OR_ZERO rather than its implementation
misc: mic: Use PTR_ERR_OR_ZERO rather than its implementation
phy: tegra: Use PTR_ERR_OR_ZERO rather than its implementation
rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its implementation

drivers/bus/ti-sysc.c | 4 +---
drivers/misc/mic/scif/scif_epd.h | 5 ++---
drivers/phy/tegra/phy-tegra194-p2u.c | 4 +---
drivers/rtc/rtc-ds1347.c | 5 +----
4 files changed, 5 insertions(+), 13 deletions(-)

--
1.7.12.4

2019-09-05 07:38:41

by zhong jiang

Subject: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its implementation

PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
use it directly. hence just replace it.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/rtc/rtc-ds1347.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
index d392a7b..5a64eea 100644
--- a/drivers/rtc/rtc-ds1347.c
+++ b/drivers/rtc/rtc-ds1347.c
@@ -151,10 +151,7 @@ static int ds1347_probe(struct spi_device *spi)
rtc = devm_rtc_device_register(&spi->dev, "ds1347",
&ds1347_rtc_ops, THIS_MODULE);

- if (IS_ERR(rtc))
- return PTR_ERR(rtc);
-
- return 0;
+ return PTR_ERR_OR_ZERO(rtc);
}

static struct spi_driver ds1347_driver = {
--
1.7.12.4

2019-09-05 08:01:24

by Alexandre Belloni

Subject: Re: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its implementation

On 05/09/2019 14:43:15+0800, zhong jiang wrote:
> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
> use it directly. hence just replace it.
>

Unless you have a more significant contribution to this driver, I'm not
going to apply this patch, especially since it will have to be reverted
as soon as the probe function changes.

> Signed-off-by: zhong jiang <[email protected]>
> ---
> drivers/rtc/rtc-ds1347.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
> index d392a7b..5a64eea 100644
> --- a/drivers/rtc/rtc-ds1347.c
> +++ b/drivers/rtc/rtc-ds1347.c
> @@ -151,10 +151,7 @@ static int ds1347_probe(struct spi_device *spi)
> rtc = devm_rtc_device_register(&spi->dev, "ds1347",
> &ds1347_rtc_ops, THIS_MODULE);
>
> - if (IS_ERR(rtc))
> - return PTR_ERR(rtc);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(rtc);
> }
>
> static struct spi_driver ds1347_driver = {
> --
> 1.7.12.4
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2019-09-05 09:43:56

by zhong jiang

Subject: Re: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its implementation

On 2019/9/5 15:39, Alexandre Belloni wrote:
> On 05/09/2019 14:43:15+0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
>> use it directly. hence just replace it.
>>
> Unless you have a more significant contribution to this driver, I'm not
> going to apply this patch, especially since it will have to be reverted
> as soon as the probe function changes.
Anyway, Thanks,

Sincerely,
zhong jiang
>> Signed-off-by: zhong jiang <[email protected]>
>> ---
>> drivers/rtc/rtc-ds1347.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
>> index d392a7b..5a64eea 100644
>> --- a/drivers/rtc/rtc-ds1347.c
>> +++ b/drivers/rtc/rtc-ds1347.c
>> @@ -151,10 +151,7 @@ static int ds1347_probe(struct spi_device *spi)
>> rtc = devm_rtc_device_register(&spi->dev, "ds1347",
>> &ds1347_rtc_ops, THIS_MODULE);
>>
>> - if (IS_ERR(rtc))
>> - return PTR_ERR(rtc);
>> -
>> - return 0;
>> + return PTR_ERR_OR_ZERO(rtc);
>> }
>>
>> static struct spi_driver ds1347_driver = {
>> --
>> 1.7.12.4
>>