2019-09-05 23:06:02

by Vivek Goyal

[permalink] [raw]

Subject: [PATCH 05/18] Maintain count of in flight requests for VQ_REQUEST queue

---

As of now we maintain this count only for VQ_HIPRIO. Maintain it for
VQ_REQUEST as well so that later it can be used to drain VQ_REQUEST
queue.

Signed-off-by: Vivek Goyal <[email protected]>
---
fs/fuse/virtio_fs.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index c46dd4d284d6..5df97dfee37d 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -360,6 +360,9 @@ static void virtio_fs_requests_done_work(struct work_struct *work)
spin_unlock(&fpq->lock);

fuse_request_end(fc, req);
+ spin_lock(&fsvq->lock);
+ fsvq->in_flight--;
+ spin_unlock(&fsvq->lock);
}
}

@@ -769,6 +772,7 @@ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq,
goto out;
}

+ fsvq->in_flight++;
notify = virtqueue_kick_prepare(vq);

spin_unlock(&fsvq->lock);
--
2.20.1

2019-09-06 16:00:24

by Stefan Hajnoczi

[permalink] [raw]

Subject: Re: [PATCH 05/18] Maintain count of in flight requests for VQ_REQUEST queue

---

On Thu, Sep 05, 2019 at 03:48:46PM -0400, Vivek Goyal wrote:
> As of now we maintain this count only for VQ_HIPRIO. Maintain it for
> VQ_REQUEST as well so that later it can be used to drain VQ_REQUEST
> queue.
>
> Signed-off-by: Vivek Goyal <[email protected]>
> ---
> fs/fuse/virtio_fs.c | 4 ++++
> 1 file changed, 4 insertions(+)

Reviewed-by: Stefan Hajnoczi <[email protected]>

---

Attachments:

(No filename) (399.00 B)
signature.asc (499.00 B)
Download all attachments