2019-09-05 23:04:38

by Vivek Goyal

[permalink] [raw]

Subject: [PATCH 09/18] virtiofs: Add an helper to start all the queues

---

This just marks are the queues are connected and ready to accept the
request.

Signed-off-by: Vivek Goyal <[email protected]>
---
fs/fuse/virtio_fs.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index d5730a50b303..f2936daca39c 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -112,6 +112,19 @@ static void virtio_fs_drain_all_queues(struct virtio_fs *fs)
}
}

+static void virtio_fs_start_all_queues(struct virtio_fs *fs)
+{
+ struct virtio_fs_vq *fsvq;
+ int i;
+
+ for (i = 0; i < fs->nvqs; i++) {
+ fsvq = &fs->vqs[i];
+ spin_lock(&fsvq->lock);
+ fsvq->connected = true;
+ spin_unlock(&fsvq->lock);
+ }
+}
+
/* Add a new instance to the list or return -EEXIST if tag name exists*/
static int virtio_fs_add_instance(struct virtio_fs *fs)
{
@@ -483,10 +496,10 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
if (ret < 0)
goto out;

- for (i = 0; i < fs->nvqs; i++) {
+ for (i = 0; i < fs->nvqs; i++)
fs->vqs[i].vq = vqs[i];
- fs->vqs[i].connected = true;
- }
+
+ virtio_fs_start_all_queues(fs);
out:
kfree(names);
kfree(callbacks);
--
2.20.1

2019-09-06 16:12:43

by Stefan Hajnoczi

[permalink] [raw]

Subject: Re: [PATCH 09/18] virtiofs: Add an helper to start all the queues

---

On Thu, Sep 05, 2019 at 03:48:50PM -0400, Vivek Goyal wrote:
> This just marks are the queues are connected and ready to accept the
> request.
>
> Signed-off-by: Vivek Goyal <[email protected]>
> ---
> fs/fuse/virtio_fs.c | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>

---

Attachments:

(No filename) (363.00 B)
signature.asc (499.00 B)
Download all attachments