2019-09-17 09:44:12

by Ran Wang

[permalink] [raw]
Subject: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name

lx2160a support PW15 but not PW20, correct name to avoid confusing.

Signed-off-by: Ran Wang <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 36 +++++++++++++-------------
1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 408e0ec..b032f38 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -33,7 +33,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster0_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@1 {
@@ -49,7 +49,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster0_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@100 {
@@ -65,7 +65,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster1_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@101 {
@@ -81,7 +81,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster1_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@200 {
@@ -97,7 +97,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster2_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@201 {
@@ -113,7 +113,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster2_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@300 {
@@ -129,7 +129,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster3_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@301 {
@@ -145,7 +145,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster3_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@400 {
@@ -161,7 +161,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster4_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@401 {
@@ -177,7 +177,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster4_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@500 {
@@ -193,7 +193,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster5_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@501 {
@@ -209,7 +209,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster5_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@600 {
@@ -225,7 +225,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster6_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@601 {
@@ -241,7 +241,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster6_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@700 {
@@ -257,7 +257,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster7_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cpu@701 {
@@ -273,7 +273,7 @@
i-cache-line-size = <64>;
i-cache-sets = <192>;
next-level-cache = <&cluster7_l2>;
- cpu-idle-states = <&cpu_pw20>;
+ cpu-idle-states = <&cpu_pw15>;
};

cluster0_l2: l2-cache0 {
@@ -340,9 +340,9 @@
cache-level = <2>;
};

- cpu_pw20: cpu-pw20 {
+ cpu_pw15: cpu-pw15 {
compatible = "arm,idle-state";
- idle-state-name = "PW20";
+ idle-state-name = "PW15";
arm,psci-suspend-param = <0x0>;
entry-latency-us = <2000>;
exit-latency-us = <2000>;
--
2.7.4


2019-10-07 11:54:47

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name

On Tue, Sep 17, 2019 at 03:33:56PM +0800, Ran Wang wrote:
> lx2160a support PW15 but not PW20, correct name to avoid confusing.
>
> Signed-off-by: Ran Wang <[email protected]>

Leo, agree?

Shawn

> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 36 +++++++++++++-------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 408e0ec..b032f38 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -33,7 +33,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster0_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@1 {
> @@ -49,7 +49,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster0_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@100 {
> @@ -65,7 +65,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster1_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@101 {
> @@ -81,7 +81,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster1_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@200 {
> @@ -97,7 +97,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster2_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@201 {
> @@ -113,7 +113,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster2_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@300 {
> @@ -129,7 +129,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster3_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@301 {
> @@ -145,7 +145,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster3_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@400 {
> @@ -161,7 +161,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster4_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@401 {
> @@ -177,7 +177,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster4_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@500 {
> @@ -193,7 +193,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster5_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@501 {
> @@ -209,7 +209,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster5_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@600 {
> @@ -225,7 +225,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster6_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@601 {
> @@ -241,7 +241,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster6_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@700 {
> @@ -257,7 +257,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster7_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cpu@701 {
> @@ -273,7 +273,7 @@
> i-cache-line-size = <64>;
> i-cache-sets = <192>;
> next-level-cache = <&cluster7_l2>;
> - cpu-idle-states = <&cpu_pw20>;
> + cpu-idle-states = <&cpu_pw15>;
> };
>
> cluster0_l2: l2-cache0 {
> @@ -340,9 +340,9 @@
> cache-level = <2>;
> };
>
> - cpu_pw20: cpu-pw20 {
> + cpu_pw15: cpu-pw15 {
> compatible = "arm,idle-state";
> - idle-state-name = "PW20";
> + idle-state-name = "PW15";
> arm,psci-suspend-param = <0x0>;
> entry-latency-us = <2000>;
> exit-latency-us = <2000>;
> --
> 2.7.4
>

2019-10-07 21:37:24

by Leo Li

[permalink] [raw]
Subject: RE: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name



> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: Monday, October 7, 2019 6:51 AM
> To: Ran Wang <[email protected]>; Leo Li <[email protected]>
> Cc: Rob Herring <[email protected]>; Mark Rutland
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name
>
> On Tue, Sep 17, 2019 at 03:33:56PM +0800, Ran Wang wrote:
> > lx2160a support PW15 but not PW20, correct name to avoid confusing.
> >
> > Signed-off-by: Ran Wang <[email protected]>
>
> Leo, agree?

Ya. The statement is correct.

Acked-by: Li Yang <[email protected]>

>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 36 +++++++++++++------
> -------
> > 1 file changed, 18 insertions(+), 18 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index 408e0ec..b032f38 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -33,7 +33,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster0_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@1 {
> > @@ -49,7 +49,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster0_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@100 {
> > @@ -65,7 +65,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster1_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@101 {
> > @@ -81,7 +81,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster1_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@200 {
> > @@ -97,7 +97,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster2_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@201 {
> > @@ -113,7 +113,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster2_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@300 {
> > @@ -129,7 +129,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster3_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@301 {
> > @@ -145,7 +145,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster3_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@400 {
> > @@ -161,7 +161,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster4_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@401 {
> > @@ -177,7 +177,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster4_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@500 {
> > @@ -193,7 +193,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster5_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@501 {
> > @@ -209,7 +209,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster5_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@600 {
> > @@ -225,7 +225,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster6_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@601 {
> > @@ -241,7 +241,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster6_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@700 {
> > @@ -257,7 +257,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster7_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cpu@701 {
> > @@ -273,7 +273,7 @@
> > i-cache-line-size = <64>;
> > i-cache-sets = <192>;
> > next-level-cache = <&cluster7_l2>;
> > - cpu-idle-states = <&cpu_pw20>;
> > + cpu-idle-states = <&cpu_pw15>;
> > };
> >
> > cluster0_l2: l2-cache0 {
> > @@ -340,9 +340,9 @@
> > cache-level = <2>;
> > };
> >
> > - cpu_pw20: cpu-pw20 {
> > + cpu_pw15: cpu-pw15 {
> > compatible = "arm,idle-state";
> > - idle-state-name = "PW20";
> > + idle-state-name = "PW15";
> > arm,psci-suspend-param = <0x0>;
> > entry-latency-us = <2000>;
> > exit-latency-us = <2000>;
> > --
> > 2.7.4
> >

2019-10-14 05:45:06

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: lx2160a: Correct CPU core idle state name

On Tue, Sep 17, 2019 at 03:33:56PM +0800, Ran Wang wrote:
> lx2160a support PW15 but not PW20, correct name to avoid confusing.
>
> Signed-off-by: Ran Wang <[email protected]>

Applied, thanks.