2019-09-22 22:30:46

by Mihail Atanassov

Subject: [PATCH] drm/komeda: Fix typos in komeda_splitter_validate

Fix both the string and the struct member being printed.

Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
index 950235af1e79..de64a6a9964e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
@@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
}

if (!in_range(&splitter->vsize, dflow->in_h)) {
- DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
- dflow->in_w);
+ DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
+ dflow->in_h);
return -EINVAL;
}

--
2.23.0

2019-09-25 02:14:49

by James Qian Wang

Subject: Re: [PATCH] drm/komeda: Fix typos in komeda_splitter_validate

Hi Mihail

On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
>
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> }
>
> if (!in_range(&splitter->vsize, dflow->in_h)) {
> - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> - dflow->in_w);
> + DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",
> + dflow->in_h);


Thank you for the patch.

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>

> return -EINVAL;
> }
>
> --
> 2.23.0

2019-09-27 12:34:46

by Liviu Dudau

Subject: Re: [PATCH] drm/komeda: Fix typos in komeda_splitter_validate

On Fri, Sep 20, 2019 at 03:11:34PM +0000, Mihail Atanassov wrote:
> Fix both the string and the struct member being printed.
>
> Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> index 950235af1e79..de64a6a9964e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> }
>
> if (!in_range(&splitter->vsize, dflow->in_h)) {
> - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> - dflow->in_w);
> + DRM_DEBUG_ATOMIC("split in_h: %d exceed the acceptable range.\n",

Being pedandic: s/exceed/exceeds/.

Best regards,
Liviu

> + dflow->in_h);
> return -EINVAL;
> }
>
> --
> 2.23.0
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯