2019-09-20 23:25:51

by Keerthy

[permalink] [raw]
Subject: [PATCH v2 linux-next 0/4] arm/arm64: configs: Convert all CONFIG_REMOTEPROC instances to y

Commit 6334150e9 changes CONFIG_REMOTEPROC to a boolean config
option that inhibits all defconfigs marking CONFIG_REMOTEPROC as
a module in compiling the remoteproc and dependent config options.

So convert all the instances to built in.

Boot tested for omap2plus_defconfig for dra7/am4/am3.

Any quick testing on other boards welcome.

Patches apply on top of linux-next branch

Changes in v2:

Cc the right lists.

Keerthy (4):
arm: configs: omap2plus_defconfig: Change CONFIG_REMOTEPROC from m to
y
arm: configs: davinci_all_defconfig: Change CONFIG_REMOTEPROC from m
to y
arm: configs: multi_v7_defconfig: Change CONFIG_REMOTEPROC from m to
y
arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y

arch/arm/configs/davinci_all_defconfig | 2 +-
arch/arm/configs/multi_v7_defconfig | 2 +-
arch/arm/configs/omap2plus_defconfig | 2 +-
arch/arm64/configs/defconfig | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

--
2.17.1


2019-09-20 23:27:01

by Keerthy

[permalink] [raw]
Subject: [PATCH v2 linux-next 3/4] arm: configs: multi_v7_defconfig: Change CONFIG_REMOTEPROC from m to y

Commit 6334150e9a36 ("remoteproc: don't allow modular build")
changes CONFIG_REMOTEPROC to a boolean from a tristate config
option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
a module in compiling the remoteproc and dependent config options.

So fix the multi_v7_defconfig to have CONFIG_REMOTEPROC built in.

Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
Signed-off-by: Keerthy <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 13ba53286901..198de8e36d92 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -933,7 +933,7 @@ CONFIG_BCM2835_MBOX=y
CONFIG_ROCKCHIP_IOMMU=y
CONFIG_TEGRA_IOMMU_GART=y
CONFIG_TEGRA_IOMMU_SMMU=y
-CONFIG_REMOTEPROC=m
+CONFIG_REMOTEPROC=y
CONFIG_ST_REMOTEPROC=m
CONFIG_RPMSG_VIRTIO=m
CONFIG_ASPEED_LPC_CTRL=m
--
2.17.1

2019-09-20 23:28:12

by Keerthy

[permalink] [raw]
Subject: [PATCH v2 linux-next 4/4] arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y

Commit 6334150e9a36 ("remoteproc: don't allow modular build")
changes CONFIG_REMOTEPROC to a boolean from a tristate config
option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
a module in compiling the remoteproc and dependent config options.

So fix the defconfig to have CONFIG_REMOTEPROC built in.

Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
Signed-off-by: Keerthy <[email protected]>
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 8e05c39eab08..c9a867ac32d4 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -723,7 +723,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
CONFIG_ARM_SMMU=y
CONFIG_ARM_SMMU_V3=y
CONFIG_QCOM_IOMMU=y
-CONFIG_REMOTEPROC=m
+CONFIG_REMOTEPROC=y
CONFIG_QCOM_Q6V5_MSS=m
CONFIG_QCOM_Q6V5_PAS=m
CONFIG_QCOM_SYSMON=m
--
2.17.1

2019-09-26 09:49:14

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH v2 linux-next 0/4] arm/arm64: configs: Convert all CONFIG_REMOTEPROC instances to y

Thanks Keerthy,

the patches look good to me:

Acked-by: Christoph Hellwig <[email protected]>

2019-09-30 13:50:45

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH v2 linux-next 4/4] arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y

On Fri, Sep 20, 2019 at 01:29:46PM +0530, Keerthy wrote:
> Commit 6334150e9a36 ("remoteproc: don't allow modular build")
> changes CONFIG_REMOTEPROC to a boolean from a tristate config
> option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
> a module in compiling the remoteproc and dependent config options.
>
> So fix the defconfig to have CONFIG_REMOTEPROC built in.
>
> Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
> Signed-off-by: Keerthy <[email protected]>
> ---
> arch/arm64/configs/defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 8e05c39eab08..c9a867ac32d4 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -723,7 +723,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
> CONFIG_ARM_SMMU=y
> CONFIG_ARM_SMMU_V3=y
> CONFIG_QCOM_IOMMU=y
> -CONFIG_REMOTEPROC=m
> +CONFIG_REMOTEPROC=y
> CONFIG_QCOM_Q6V5_MSS=m
> CONFIG_QCOM_Q6V5_PAS=m
> CONFIG_QCOM_SYSMON=m

Acked-by: Will Deacon <[email protected]>

This fixes the following annoying warning from "make defconfig" on arm64:

arch/arm64/configs/defconfig:726:warning: symbol value 'm' invalid for REMOTEPROC

I'm assuming the fix will go via arm-soc, but I can take it otherwise
(please just let me know).

Will

2019-09-30 20:43:49

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH v2 linux-next 4/4] arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y

On Mon, Sep 30, 2019 at 6:49 AM Will Deacon <[email protected]> wrote:
>
> On Fri, Sep 20, 2019 at 01:29:46PM +0530, Keerthy wrote:
> > Commit 6334150e9a36 ("remoteproc: don't allow modular build")
> > changes CONFIG_REMOTEPROC to a boolean from a tristate config
> > option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
> > a module in compiling the remoteproc and dependent config options.
> >
> > So fix the defconfig to have CONFIG_REMOTEPROC built in.
> >
> > Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
> > Signed-off-by: Keerthy <[email protected]>
> > ---
> > arch/arm64/configs/defconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 8e05c39eab08..c9a867ac32d4 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -723,7 +723,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
> > CONFIG_ARM_SMMU=y
> > CONFIG_ARM_SMMU_V3=y
> > CONFIG_QCOM_IOMMU=y
> > -CONFIG_REMOTEPROC=m
> > +CONFIG_REMOTEPROC=y
> > CONFIG_QCOM_Q6V5_MSS=m
> > CONFIG_QCOM_Q6V5_PAS=m
> > CONFIG_QCOM_SYSMON=m
>
> Acked-by: Will Deacon <[email protected]>
>
> This fixes the following annoying warning from "make defconfig" on arm64:
>
> arch/arm64/configs/defconfig:726:warning: symbol value 'm' invalid for REMOTEPROC
>
> I'm assuming the fix will go via arm-soc, but I can take it otherwise
> (please just let me know).

Thanks, I'll pick this up, but I'll squash the 4 one-line changes into
one commit instead of separate patches.


-Olof

2019-09-30 23:12:32

by Keerthy

[permalink] [raw]
Subject: Re: [PATCH v2 linux-next 4/4] arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y



On 10/1/2019 12:16 AM, Olof Johansson wrote:
> On Mon, Sep 30, 2019 at 6:49 AM Will Deacon <[email protected]> wrote:
>>
>> On Fri, Sep 20, 2019 at 01:29:46PM +0530, Keerthy wrote:
>>> Commit 6334150e9a36 ("remoteproc: don't allow modular build")
>>> changes CONFIG_REMOTEPROC to a boolean from a tristate config
>>> option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
>>> a module in compiling the remoteproc and dependent config options.
>>>
>>> So fix the defconfig to have CONFIG_REMOTEPROC built in.
>>>
>>> Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
>>> Signed-off-by: Keerthy <[email protected]>
>>> ---
>>> arch/arm64/configs/defconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 8e05c39eab08..c9a867ac32d4 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -723,7 +723,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
>>> CONFIG_ARM_SMMU=y
>>> CONFIG_ARM_SMMU_V3=y
>>> CONFIG_QCOM_IOMMU=y
>>> -CONFIG_REMOTEPROC=m
>>> +CONFIG_REMOTEPROC=y
>>> CONFIG_QCOM_Q6V5_MSS=m
>>> CONFIG_QCOM_Q6V5_PAS=m
>>> CONFIG_QCOM_SYSMON=m
>>
>> Acked-by: Will Deacon <[email protected]>
>>
>> This fixes the following annoying warning from "make defconfig" on arm64:
>>
>> arch/arm64/configs/defconfig:726:warning: symbol value 'm' invalid for REMOTEPROC
>>
>> I'm assuming the fix will go via arm-soc, but I can take it otherwise
>> (please just let me know).
>
> Thanks, I'll pick this up, but I'll squash the 4 one-line changes into
> one commit instead of separate patches.

Thanks Olof.

>
>
> -Olof
>