2019-10-01 18:17:11

by Evan Green

Subject: [PATCH v3] Input: atmel_mxt_ts - Disable IRQ across suspend

Across suspend and resume, we are seeing error messages like the following:

atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121)
atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121)

This occurs because the driver leaves its IRQ enabled. Upon resume, there
is an IRQ pending, but the interrupt is serviced before both the driver and
the underlying I2C bus have been resumed. This causes EREMOTEIO errors.

Disable the IRQ in suspend, and re-enable it on resume. If there are cases
where the driver enters suspend with interrupts disabled, that's a bug we
should fix separately.

Signed-off-by: Evan Green <[email protected]>
---

Changes in v3:
- Move enable_irq to the beginning of resume (Dmitry)

Changes in v2:
- Enable and disable unconditionally (Dmitry)

drivers/input/touchscreen/atmel_mxt_ts.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 24c4b691b1c9..1627fcb27f35 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -3155,6 +3155,7 @@ static int __maybe_unused mxt_suspend(struct device *dev)
mxt_stop(data);

mutex_unlock(&input_dev->mutex);
+ disable_irq(data->irq);

return 0;
}
@@ -3168,6 +3169,7 @@ static int __maybe_unused mxt_resume(struct device *dev)
if (!input_dev)
return 0;

+ enable_irq(data->irq);
mutex_lock(&input_dev->mutex);

if (input_dev->users)
--
2.21.0

2019-10-02 21:56:07

by Dmitry Torokhov

Subject: Re: [PATCH v3] Input: atmel_mxt_ts - Disable IRQ across suspend

On Tue, Oct 01, 2019 at 11:15:03AM -0700, Evan Green wrote:
> Across suspend and resume, we are seeing error messages like the following:
>
> atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121)
> atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121)
>
> This occurs because the driver leaves its IRQ enabled. Upon resume, there
> is an IRQ pending, but the interrupt is serviced before both the driver and
> the underlying I2C bus have been resumed. This causes EREMOTEIO errors.
>
> Disable the IRQ in suspend, and re-enable it on resume. If there are cases
> where the driver enters suspend with interrupts disabled, that's a bug we
> should fix separately.
>
> Signed-off-by: Evan Green <[email protected]>

Applied, thank you.

> ---
>
> Changes in v3:
> - Move enable_irq to the beginning of resume (Dmitry)
>
> Changes in v2:
> - Enable and disable unconditionally (Dmitry)
>
> drivers/input/touchscreen/atmel_mxt_ts.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index 24c4b691b1c9..1627fcb27f35 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -3155,6 +3155,7 @@ static int __maybe_unused mxt_suspend(struct device *dev)
> mxt_stop(data);
>
> mutex_unlock(&input_dev->mutex);
> + disable_irq(data->irq);
>
> return 0;
> }
> @@ -3168,6 +3169,7 @@ static int __maybe_unused mxt_resume(struct device *dev)
> if (!input_dev)
> return 0;
>
> + enable_irq(data->irq);
> mutex_lock(&input_dev->mutex);
>
> if (input_dev->users)
> --
> 2.21.0
>

--
Dmitry