Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/sound/sof/dai-imx.h:11,
from <command-line>:
include/sound/sof/header.h:125:2: error: unknown type name 'uint32_t'
125 | uint32_t size; /**< size of structure */
| ^~~~~~~~
include/sound/sof/header.h:136:2: error: unknown type name 'uint32_t'
136 | uint32_t size; /**< size of structure */
| ^~~~~~~~
include/sound/sof/header.h:137:2: error: unknown type name 'uint32_t'
137 | uint32_t cmd; /**< SOF_IPC_GLB_ + cmd */
| ^~~~~~~~
include/sound/sof/header.h:146:2: error: unknown type name 'int32_t'
146 | int32_t error; /**< negative error numbers */
| ^~~~~~~
include/sound/sof/header.h:160:2: error: unknown type name 'uint32_t'
160 | uint32_t count; /**< count of 0 means end of compound sequence */
| ^~~~~~~~
include/sound/sof/header.h:167:2: error: unknown type name 'uint32_t'
167 | uint32_t arch; /* Identifier of architecture */
| ^~~~~~~~
include/sound/sof/header.h:168:2: error: unknown type name 'uint32_t'
168 | uint32_t totalsize; /* Total size of oops message */
| ^~~~~~~~
include/sound/sof/header.h:175:2: error: unknown type name 'uint32_t'
175 | uint32_t configidhi; /* ConfigID hi 32bits */
| ^~~~~~~~
include/sound/sof/header.h:176:2: error: unknown type name 'uint32_t'
176 | uint32_t configidlo; /* ConfigID lo 32bits */
| ^~~~~~~~
include/sound/sof/header.h:177:2: error: unknown type name 'uint32_t'
177 | uint32_t numaregs; /* Special regs num */
| ^~~~~~~~
include/sound/sof/header.h:178:2: error: unknown type name 'uint32_t'
178 | uint32_t stackoffset; /* Offset to stack pointer from beginning of
| ^~~~~~~~
include/sound/sof/header.h:181:2: error: unknown type name 'uint32_t'
181 | uint32_t stackptr; /* Stack ptr */
| ^~~~~~~~
In file included from <command-line>:
include/sound/sof/dai-imx.h:18:2: error: unknown type name 'uint16_t'
18 | uint16_t reserved1;
| ^~~~~~~~
include/sound/sof/dai-imx.h:19:2: error: unknown type name 'uint16_t'
19 | uint16_t mclk_id;
| ^~~~~~~~
include/sound/sof/dai-imx.h:20:2: error: unknown type name 'uint32_t'
20 | uint32_t mclk_direction;
| ^~~~~~~~
include/sound/sof/dai-imx.h:22:2: error: unknown type name 'uint32_t'
22 | uint32_t mclk_rate; /* MCLK frequency in Hz */
| ^~~~~~~~
include/sound/sof/dai-imx.h:23:2: error: unknown type name 'uint32_t'
23 | uint32_t fsync_rate; /* FSYNC frequency in Hz */
| ^~~~~~~~
include/sound/sof/dai-imx.h:24:2: error: unknown type name 'uint32_t'
24 | uint32_t bclk_rate; /* BCLK frequency in Hz */
| ^~~~~~~~
include/sound/sof/dai-imx.h:27:2: error: unknown type name 'uint32_t'
27 | uint32_t tdm_slots;
| ^~~~~~~~
include/sound/sof/dai-imx.h:28:2: error: unknown type name 'uint32_t'
28 | uint32_t rx_slots;
| ^~~~~~~~
include/sound/sof/dai-imx.h:29:2: error: unknown type name 'uint32_t'
29 | uint32_t tx_slots;
| ^~~~~~~~
include/sound/sof/dai-imx.h:30:2: error: unknown type name 'uint16_t'
30 | uint16_t tdm_slot_width;
| ^~~~~~~~
include/sound/sof/dai-imx.h:31:2: error: unknown type name 'uint16_t'
31 | uint16_t reserved2; /* alignment */
| ^~~~~~~~
Caused by commit
b4be427683cf ("ASoC: SOF: imx: Describe ESAI parameters to be sent to DSP")
I added the following fix for today (include/sound/sof/header.h
probably should have something similar):
From: Stephen Rothwell <[email protected]>
Date: Fri, 11 Oct 2019 10:56:46 +1100
Subject: [PATCH] ASOC: SOF: dai-imx.h needs linux/types.h
Signed-off-by: Stephen Rothwell <[email protected]>
---
include/sound/sof/dai-imx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/sound/sof/dai-imx.h b/include/sound/sof/dai-imx.h
index e02fb0b0fae1..31ccb87a8273 100644
--- a/include/sound/sof/dai-imx.h
+++ b/include/sound/sof/dai-imx.h
@@ -8,6 +8,7 @@
#ifndef __INCLUDE_SOUND_SOF_DAI_IMX_H__
#define __INCLUDE_SOUND_SOF_DAI_IMX_H__
+#include <linux/types.h>
#include <sound/sof/header.h>
/* ESAI Configuration Request - SOF_IPC_DAI_ESAI_CONFIG */
--
2.23.0
--
Cheers,
Stephen Rothwell
Hi Stephen,
On Fri, Oct 11, 2019 at 3:04 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/sound/sof/dai-imx.h:11,
> from <command-line>:
> include/sound/sof/header.h:125:2: error: unknown type name 'uint32_t'
> 125 | uint32_t size; /**< size of structure */
> | ^~~~~~~~
> include/sound/sof/header.h:136:2: error: unknown type name 'uint32_t'
> 136 | uint32_t size; /**< size of structure */
> | ^~~~~~~~
> include/sound/sof/header.h:137:2: error: unknown type name 'uint32_t'
> 137 | uint32_t cmd; /**< SOF_IPC_GLB_ + cmd */
> | ^~~~~~~~
> include/sound/sof/header.h:146:2: error: unknown type name 'int32_t'
> 146 | int32_t error; /**< negative error numbers */
> | ^~~~~~~
> include/sound/sof/header.h:160:2: error: unknown type name 'uint32_t'
> 160 | uint32_t count; /**< count of 0 means end of compound sequence */
> | ^~~~~~~~
> include/sound/sof/header.h:167:2: error: unknown type name 'uint32_t'
> 167 | uint32_t arch; /* Identifier of architecture */
> | ^~~~~~~~
> include/sound/sof/header.h:168:2: error: unknown type name 'uint32_t'
> 168 | uint32_t totalsize; /* Total size of oops message */
> | ^~~~~~~~
> include/sound/sof/header.h:175:2: error: unknown type name 'uint32_t'
> 175 | uint32_t configidhi; /* ConfigID hi 32bits */
> | ^~~~~~~~
> include/sound/sof/header.h:176:2: error: unknown type name 'uint32_t'
> 176 | uint32_t configidlo; /* ConfigID lo 32bits */
> | ^~~~~~~~
> include/sound/sof/header.h:177:2: error: unknown type name 'uint32_t'
> 177 | uint32_t numaregs; /* Special regs num */
> | ^~~~~~~~
> include/sound/sof/header.h:178:2: error: unknown type name 'uint32_t'
> 178 | uint32_t stackoffset; /* Offset to stack pointer from beginning of
> | ^~~~~~~~
> include/sound/sof/header.h:181:2: error: unknown type name 'uint32_t'
> 181 | uint32_t stackptr; /* Stack ptr */
> | ^~~~~~~~
> In file included from <command-line>:
> include/sound/sof/dai-imx.h:18:2: error: unknown type name 'uint16_t'
> 18 | uint16_t reserved1;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:19:2: error: unknown type name 'uint16_t'
> 19 | uint16_t mclk_id;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:20:2: error: unknown type name 'uint32_t'
> 20 | uint32_t mclk_direction;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:22:2: error: unknown type name 'uint32_t'
> 22 | uint32_t mclk_rate; /* MCLK frequency in Hz */
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:23:2: error: unknown type name 'uint32_t'
> 23 | uint32_t fsync_rate; /* FSYNC frequency in Hz */
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:24:2: error: unknown type name 'uint32_t'
> 24 | uint32_t bclk_rate; /* BCLK frequency in Hz */
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:27:2: error: unknown type name 'uint32_t'
> 27 | uint32_t tdm_slots;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:28:2: error: unknown type name 'uint32_t'
> 28 | uint32_t rx_slots;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:29:2: error: unknown type name 'uint32_t'
> 29 | uint32_t tx_slots;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:30:2: error: unknown type name 'uint16_t'
> 30 | uint16_t tdm_slot_width;
> | ^~~~~~~~
> include/sound/sof/dai-imx.h:31:2: error: unknown type name 'uint16_t'
> 31 | uint16_t reserved2; /* alignment */
> | ^~~~~~~~
>
> Caused by commit
>
> b4be427683cf ("ASoC: SOF: imx: Describe ESAI parameters to be sent to DSP")
>
> I added the following fix for today (include/sound/sof/header.h
> probably should have something similar):
Thanks for doing this! Is this patch in linux-next already? I couldn't find it.
For include/sound/sof/header.h Morimoto-san sent a patch to alsa-devel.
>
> From: Stephen Rothwell <[email protected]>
> Date: Fri, 11 Oct 2019 10:56:46 +1100
> Subject: [PATCH] ASOC: SOF: dai-imx.h needs linux/types.h
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> include/sound/sof/dai-imx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/sof/dai-imx.h b/include/sound/sof/dai-imx.h
> index e02fb0b0fae1..31ccb87a8273 100644
> --- a/include/sound/sof/dai-imx.h
> +++ b/include/sound/sof/dai-imx.h
> @@ -8,6 +8,7 @@
> #ifndef __INCLUDE_SOUND_SOF_DAI_IMX_H__
> #define __INCLUDE_SOUND_SOF_DAI_IMX_H__
>
> +#include <linux/types.h>
> #include <sound/sof/header.h>
>
> /* ESAI Configuration Request - SOF_IPC_DAI_ESAI_CONFIG */
> --
> 2.23.0
>
> --
> Cheers,
> Stephen Rothwell
Hi Daniel,
On Tue, 15 Oct 2019 09:46:33 +0300 Daniel Baluta <[email protected]> wrote:
>
> > I added the following fix for today (include/sound/sof/header.h
> > probably should have something similar):
>
> Thanks for doing this! Is this patch in linux-next already? I couldn't find it.
Its part of the commit that merges the cound-asoc tree i.e. not a
separate commit, but sould be applied to the sound-asoc tree itself.
> For include/sound/sof/header.h Morimoto-san sent a patch to alsa-devel.
Great, thanks.
--
Cheers,
Stephen Rothwell