2019-10-14 19:14:52

by Jerry Snitselaar

Subject: [PATCH] efi/tpm: return -EINVAL when determining tpm final events log size fails

Currently nothing checks the return value of efi_tpm_eventlog_init,
but in case that changes in the future make sure an error is
returned when it fails to determine the tpm final events log
size.

Cc: Ard Biesheuvel <[email protected]>
Cc: Jarkko Sakkinen <[email protected]>
Cc: [email protected]
Cc: [email protected]
Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing")
Suggested-by: Dan Carpenter <[email protected]>
Signed-off-by: Jerry Snitselaar <[email protected]>
---
drivers/firmware/efi/tpm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
index ebd7977653a8..31f9f0e369b9 100644
--- a/drivers/firmware/efi/tpm.c
+++ b/drivers/firmware/efi/tpm.c
@@ -88,6 +88,7 @@ int __init efi_tpm_eventlog_init(void)

if (tbl_size < 0) {
pr_err(FW_BUG "Failed to parse event in TPM Final Events Log\n");
+ ret = -EINVAL;
goto out_calc;
}

--
2.23.0

2019-10-16 14:48:25

by Jarkko Sakkinen

Subject: Re: [PATCH] efi/tpm: return -EINVAL when determining tpm final events log size fails

On Mon, Oct 14, 2019 at 10:21:45AM -0700, Jerry Snitselaar wrote:
> Currently nothing checks the return value of efi_tpm_eventlog_init,
> but in case that changes in the future make sure an error is
> returned when it fails to determine the tpm final events log
> size.
>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Jarkko Sakkinen <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing")
> Suggested-by: Dan Carpenter <[email protected]>
> Signed-off-by: Jerry Snitselaar <[email protected]>

Reviewed-by: Jarkko Sakkinen <[email protected]>

/Jarkko