2019-10-28 21:10:34

by Jessica Yu

Subject: `make nsdeps` prints "Building modules, stage 2" twice

Hi!

When running `make nsdeps`, I've noticed that "Building modules, stage
2" gets printed twice. Not a big deal, but a bit strange to see,
especially since the second print is actually from the nsdeps target
calling modpost again.

$ make nsdeps O=/dev/shm/linux
make[1]: Entering directory '/dev/shm/linux'
GEN Makefile
DESCEND objtool
CALL /tmp/ppyu/linux/scripts/atomic/check-atomics.sh
CALL /tmp/ppyu/linux/scripts/checksyscalls.sh
CHK include/generated/compile.h
Building modules, stage 2.
MODPOST 3316 modules
Building modules, stage 2.
MODPOST 3316 modules
Adding namespace USB_STORAGE to module uas (if needed).
Adding namespace USB_STORAGE to module ums-alauda (if needed).
Adding namespace USB_STORAGE to module ums-cypress (if needed).
Adding namespace USB_STORAGE to module ums-datafab (if needed).
....etc...

It's due to calling the __modpost target twice, once for modules and
once for nsdeps. I guess we could have the nsdeps target just call
cmd_modpost, but then we still have the MODPOST XXXX modules line
printing twice. Is there a nicer way to fix this? Again, it's not
harmful, but probably confusing for people to see.

Thanks,

Jessica

2019-10-29 10:19:29

by Masahiro Yamada

Subject: Re: `make nsdeps` prints "Building modules, stage 2" twice

On Tue, Oct 29, 2019 at 12:33 AM Jessica Yu <[email protected]> wrote:
>
> Hi!
>
> When running `make nsdeps`, I've noticed that "Building modules, stage
> 2" gets printed twice. Not a big deal, but a bit strange to see,
> especially since the second print is actually from the nsdeps target
> calling modpost again.
>
> $ make nsdeps O=/dev/shm/linux
> make[1]: Entering directory '/dev/shm/linux'
> GEN Makefile
> DESCEND objtool
> CALL /tmp/ppyu/linux/scripts/atomic/check-atomics.sh
> CALL /tmp/ppyu/linux/scripts/checksyscalls.sh
> CHK include/generated/compile.h
> Building modules, stage 2.
> MODPOST 3316 modules
> Building modules, stage 2.
> MODPOST 3316 modules
> Adding namespace USB_STORAGE to module uas (if needed).
> Adding namespace USB_STORAGE to module ums-alauda (if needed).
> Adding namespace USB_STORAGE to module ums-cypress (if needed).
> Adding namespace USB_STORAGE to module ums-datafab (if needed).
> ....etc...
>
> It's due to calling the __modpost target twice, once for modules and
> once for nsdeps. I guess we could have the nsdeps target just call
> cmd_modpost, but then we still have the MODPOST XXXX modules line
> printing twice. Is there a nicer way to fix this? Again, it's not
> harmful, but probably confusing for people to see.
>
> Thanks,
>
> Jessica

I can fix this correctly.
Will send a patch soon.


--
Best Regards
Masahiro Yamada