This driver forgets to kill tasklet in remove.
Add the call to fix it.
Signed-off-by: Chuhong Yuan <[email protected]>
---
Changes in v2:
- Rebase on net-next.
drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 8fc2e21f0bb1..7bf86b84b143 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4418,6 +4418,7 @@ static int macb_remove(struct platform_device *pdev)
if (dev) {
bp = netdev_priv(dev);
+ tasklet_kill(&bp->hresp_err_tasklet);
mdiobus_unregister(bp->mii_bus);
mdiobus_free(bp->mii_bus);
--
2.24.0
From: Chuhong Yuan <[email protected]>
Date: Sat, 16 Nov 2019 22:23:10 +0800
> This driver forgets to kill tasklet in remove.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> Changes in v2:
> - Rebase on net-next.
Does this bug exist in mainline? Then this bug fix should target 'net'.
You must also provide an appropriate Fixes: tag which indicates the commit
which introduced this bug.
Thank you.
On Sun, Nov 17, 2019 at 4:17 AM David Miller <[email protected]> wrote:
>
> From: Chuhong Yuan <[email protected]>
> Date: Sat, 16 Nov 2019 22:23:10 +0800
>
> > This driver forgets to kill tasklet in remove.
> > Add the call to fix it.
> >
> > Signed-off-by: Chuhong Yuan <[email protected]>
> > ---
> > Changes in v2:
> > - Rebase on net-next.
>
> Does this bug exist in mainline? Then this bug fix should target 'net'.
>
This bug exists in mainline but this file has been modified in net-next, so
the line number is a little different.
> You must also provide an appropriate Fixes: tag which indicates the commit
> which introduced this bug.
>
> Thank you.