2019-11-21 11:08:36

by Fabrice Gasnier

Subject: [PATCH] iio: trigger: stm32-timer: remove unnecessary update event

There is no need to explicitly generate update event to update
timer master mode.

Signed-off-by: Fabrice Gasnier <[email protected]>
---
drivers/iio/trigger/stm32-timer-trigger.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
index a5dfe65..2e0d32a 100644
--- a/drivers/iio/trigger/stm32-timer-trigger.c
+++ b/drivers/iio/trigger/stm32-timer-trigger.c
@@ -297,9 +297,6 @@ static ssize_t stm32_tt_store_master_mode(struct device *dev,
strlen(master_mode_table[i]))) {
regmap_update_bits(priv->regmap, TIM_CR2, mask,
i << shift);
- /* Make sure that registers are updated */
- regmap_update_bits(priv->regmap, TIM_EGR,
- TIM_EGR_UG, TIM_EGR_UG);
return len;
}
}
--
2.7.4

2019-11-23 16:47:15

by Jonathan Cameron

Subject: Re: [PATCH] iio: trigger: stm32-timer: remove unnecessary update event

On Thu, 21 Nov 2019 12:05:17 +0100
Fabrice Gasnier <[email protected]> wrote:

> There is no need to explicitly generate update event to update
> timer master mode.
>
> Signed-off-by: Fabrice Gasnier <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it

Thanks,

Jonathan

> ---
> drivers/iio/trigger/stm32-timer-trigger.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index a5dfe65..2e0d32a 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -297,9 +297,6 @@ static ssize_t stm32_tt_store_master_mode(struct device *dev,
> strlen(master_mode_table[i]))) {
> regmap_update_bits(priv->regmap, TIM_CR2, mask,
> i << shift);
> - /* Make sure that registers are updated */
> - regmap_update_bits(priv->regmap, TIM_EGR,
> - TIM_EGR_UG, TIM_EGR_UG);
> return len;
> }
> }