2019-12-02 22:07:29

by Andreas Färber

Subject: [RFC 5/5] arm64: dts: realtek: rtd139x: Add SB2 sem nodes

Add DT nodes to SB2 for hardware semaphores in RTD1395 SoC family.

Signed-off-by: Andreas Färber <[email protected]>
---
arch/arm64/boot/dts/realtek/rtd139x.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/realtek/rtd139x.dtsi b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
index a3c10ceeb586..586b05350274 100644
--- a/arch/arm64/boot/dts/realtek/rtd139x.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
@@ -191,3 +191,17 @@
status = "disabled";
};
};
+
+&sb2 {
+ sb2_hd_sem: hwspinlock@0 {
+ compatible = "realtek,rtd1195-sb2-sem";
+ reg = <0x0 0x4>;
+ #hwlock-cells = <0>;
+ };
+
+ sb2_hd_sem_new: hwspinlock@620 {
+ compatible = "realtek,rtd1195-sb2-sem";
+ reg = <0x620 0x20>;
+ #hwlock-cells = <1>;
+ };
+};
--
2.16.4

2019-12-02 23:16:26

by Andreas Färber

Subject: Re: [RFC 5/5] arm64: dts: realtek: rtd139x: Add SB2 sem nodes

Am 02.12.19 um 23:05 schrieb Andreas Färber:
> Add DT nodes to SB2 for hardware semaphores in RTD1395 SoC family.
>
> Signed-off-by: Andreas Färber <[email protected]>
> ---
> arch/arm64/boot/dts/realtek/rtd139x.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/realtek/rtd139x.dtsi b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
> index a3c10ceeb586..586b05350274 100644
> --- a/arch/arm64/boot/dts/realtek/rtd139x.dtsi
> +++ b/arch/arm64/boot/dts/realtek/rtd139x.dtsi
> @@ -191,3 +191,17 @@
> status = "disabled";
> };
> };
> +
> +&sb2 {
> + sb2_hd_sem: hwspinlock@0 {
> + compatible = "realtek,rtd1195-sb2-sem";
> + reg = <0x0 0x4>;
> + #hwlock-cells = <0>;
> + };
> +
> + sb2_hd_sem_new: hwspinlock@620 {
> + compatible = "realtek,rtd1195-sb2-sem";
> + reg = <0x620 0x20>;
> + #hwlock-cells = <1>;
> + };

Forgot to mention: These last 8 registers (0x20) are a guess, untested.
@Realtek: Can someone please check whether RTD1395 has the same nine sem
registers as RTD1295?

Similarly, this series is lacking a patch for RTD1619 because - same as
for RTD1295/RTD1395 - BSP DT only shows the first one (cf. coverletter).
Same issue for RTD1319 while at it.

Thanks,
Andreas

> +};

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)