LinuxLists.cc - Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties

2019-12-21 19:27:16

Subject: Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties

On Mon 2019-12-16 13:28:05, Guido G?nther wrote:
> We allow configuration of brightness mode and over voltage
> protection.
>
> Signed-off-by: Guido G?nther <[email protected]>
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> @@ -18,6 +18,10 @@ Required properties:
> Optional properties:
> - enable-gpios : gpio pin to enable/disable the device.
> - vled-supply : LED supply
> + - ti,brightness-mapping-exponential: Whether to use exponential
> + brightness mapping
> + - ti,overvoltage-volts: Overvoltage protection in Volts, can
> + be 0 (unprotected), 21, 25 or 29V
>

We usually use microvolts in various device tree properties...

Exponential mapping s not really property of the hardware, is it? Does
it belong here or somewhere in the backlight binding?

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:

(No filename) (985.00 B)
signature.asc (188.00 B)
Digital signature Download all attachments

2019-12-24 11:46:36

by Guido Günther

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties

Hi,
On Sat, Dec 21, 2019 at 08:15:15PM +0100, Pavel Machek wrote:
> On Mon 2019-12-16 13:28:05, Guido G?nther wrote:
> > We allow configuration of brightness mode and over voltage
> > protection.
> >
> > Signed-off-by: Guido G?nther <[email protected]>
> > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> > @@ -18,6 +18,10 @@ Required properties:
> > Optional properties:
> > - enable-gpios : gpio pin to enable/disable the device.
> > - vled-supply : LED supply
> > + - ti,brightness-mapping-exponential: Whether to use exponential
> > + brightness mapping
> > + - ti,overvoltage-volts: Overvoltage protection in Volts, can
> > + be 0 (unprotected), 21, 25 or 29V
> >
>
> We usually use microvolts in various device tree properties...

Make sense.

> Exponential mapping s not really property of the hardware, is it? Does
> it belong here or somewhere in the backlight binding?

I opted for having it with the hardware since the property can't be
configured per backlight led strip individually.

Cheers,
-- Guido

> Best regards,
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html