2019-12-28 00:40:34

by Matthew Hanzelik

Subject: [PATCH v2] Staging: wfx: Fix style issues with hif_rx.c

Fixes the 80 character line limit warning on line 79 of hif_rx.c.

Also fixes the missing blank line warning on line 305 of hif_rx.c after
the declaration of size_t len.

Signed-off-by: Matthew Hanzelik <[email protected]>
---
Changes in v2:
- Make the commit message less vague.

drivers/staging/wfx/hif_rx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
index 820de216be0c..1da9a153dda0 100644
--- a/drivers/staging/wfx/hif_rx.c
+++ b/drivers/staging/wfx/hif_rx.c
@@ -76,7 +76,8 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, struct hif_msg *hif,
void *buf)
{
struct hif_cnf_multi_transmit *body = buf;
- struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *) &body->tx_conf_payload;
+ struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *)
+ &body->tx_conf_payload;
struct wfx_vif *wvif = wdev_to_wvif(wdev, hif->interface);
int count = body->num_tx_confs;
int i;
@@ -302,6 +303,7 @@ static int hif_exception_indication(struct wfx_dev *wdev,
struct hif_msg *hif, void *buf)
{
size_t len = hif->len - 4; // drop header
+
dev_err(wdev->dev, "firmware exception\n");
print_hex_dump_bytes("Dump: ", DUMP_PREFIX_NONE, buf, len);
wdev->chip_frozen = 1;
--
2.24.1

2019-12-29 09:49:07

by Jérôme Pouiller

Subject: Re: [PATCH v2] Staging: wfx: Fix style issues with hif_rx.c

On Saturday 28 December 2019 01:38:24 CET Matthew Hanzelik wrote:
> Fixes the 80 character line limit warning on line 79 of hif_rx.c.
>
> Also fixes the missing blank line warning on line 305 of hif_rx.c after
> the declaration of size_t len.
>
> Signed-off-by: Matthew Hanzelik <[email protected]>
> ---
> Changes in v2:
> - Make the commit message less vague.
>
> drivers/staging/wfx/hif_rx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
> index 820de216be0c..1da9a153dda0 100644
> --- a/drivers/staging/wfx/hif_rx.c
> +++ b/drivers/staging/wfx/hif_rx.c
> @@ -76,7 +76,8 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, struct hif_msg *hif,
> void *buf)
> {
> struct hif_cnf_multi_transmit *body = buf;
> - struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *) &body->tx_conf_payload;
> + struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *)
> + &body->tx_conf_payload;

Since cast operator is an unary operator, I would try to avoid line break
between cast and variable. I suggest to place the break after the '='.



> struct wfx_vif *wvif = wdev_to_wvif(wdev, hif->interface);
> int count = body->num_tx_confs;
> int i;
> @@ -302,6 +303,7 @@ static int hif_exception_indication(struct wfx_dev *wdev,
> struct hif_msg *hif, void *buf)
> {
> size_t len = hif->len - 4; // drop header
> +
> dev_err(wdev->dev, "firmware exception\n");
> print_hex_dump_bytes("Dump: ", DUMP_PREFIX_NONE, buf, len);
> wdev->chip_frozen = 1;
Ack.

--
J?r?me Pouiller