2019-12-28 20:37:33

by Dmitry Osipenko

Subject: [PATCH v3 14/16] usb: chipidea: tegra: Stop managing PHY's power

Tegra's USB PHY driver now provides generic PHY init/shutdown callbacks
and thus the custom PHY management could be removed from Tegra-specific
part of the ChipIdea driver.

Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_tegra.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
index 0c9911d44ee5..7455df0ede49 100644
--- a/drivers/usb/chipidea/ci_hdrc_tegra.c
+++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
@@ -83,13 +83,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
return err;
}

- /*
- * Tegra's USB PHY driver doesn't implement optional phy_init()
- * hook, so we have to power on UDC controller before ChipIdea
- * driver initialization kicks in.
- */
- usb_phy_set_suspend(udc->phy, 0);
-
/* setup and register ChipIdea HDRC device */
udc->data.name = "tegra-udc";
udc->data.flags = soc->flags;
@@ -109,7 +102,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
return 0;

fail_power_off:
- usb_phy_set_suspend(udc->phy, 1);
clk_disable_unprepare(udc->clk);
return err;
}
@@ -119,7 +111,6 @@ static int tegra_udc_remove(struct platform_device *pdev)
struct tegra_udc *udc = platform_get_drvdata(pdev);

ci_hdrc_remove_device(udc->dev);
- usb_phy_set_suspend(udc->phy, 1);
clk_disable_unprepare(udc->clk);

return 0;
--
2.24.0

2019-12-30 02:25:39

by Peter Chen

Subject: Re: [PATCH v3 14/16] usb: chipidea: tegra: Stop managing PHY's power

On 19-12-28 23:33:56, Dmitry Osipenko wrote:
> Tegra's USB PHY driver now provides generic PHY init/shutdown callbacks
> and thus the custom PHY management could be removed from Tegra-specific
> part of the ChipIdea driver.
>
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
> drivers/usb/chipidea/ci_hdrc_tegra.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 0c9911d44ee5..7455df0ede49 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -83,13 +83,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
> return err;
> }
>
> - /*
> - * Tegra's USB PHY driver doesn't implement optional phy_init()
> - * hook, so we have to power on UDC controller before ChipIdea
> - * driver initialization kicks in.
> - */
> - usb_phy_set_suspend(udc->phy, 0);
> -
> /* setup and register ChipIdea HDRC device */
> udc->data.name = "tegra-udc";
> udc->data.flags = soc->flags;
> @@ -109,7 +102,6 @@ static int tegra_udc_probe(struct platform_device *pdev)
> return 0;
>
> fail_power_off:
> - usb_phy_set_suspend(udc->phy, 1);
> clk_disable_unprepare(udc->clk);
> return err;
> }
> @@ -119,7 +111,6 @@ static int tegra_udc_remove(struct platform_device *pdev)
> struct tegra_udc *udc = platform_get_drvdata(pdev);
>
> ci_hdrc_remove_device(udc->dev);
> - usb_phy_set_suspend(udc->phy, 1);
> clk_disable_unprepare(udc->clk);
>
> return 0;
> --
> 2.24.0
>

Acked-by: Peter Chen <[email protected]>

--

Thanks,
Peter Chen