The .set_ramp_delay should be for bd70528_buck_ops only.
Setting .set_ramp_delay for for bd70528_ldo_ops causes problem because
BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT (0x1f).
So setting ramp_delay for LDOs may change the voltage output, fix it.
Fixes: 99ea37bd1e7d ("regulator: bd70528: Support ROHM BD70528 regulator block")
Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/bd70528-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/bd70528-regulator.c b/drivers/regulator/bd70528-regulator.c
index ec764022621f..5bf8a2dc5fe7 100644
--- a/drivers/regulator/bd70528-regulator.c
+++ b/drivers/regulator/bd70528-regulator.c
@@ -101,7 +101,6 @@ static const struct regulator_ops bd70528_ldo_ops = {
.set_voltage_sel = regulator_set_voltage_sel_regmap,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
.set_voltage_time_sel = regulator_set_voltage_time_sel,
- .set_ramp_delay = bd70528_set_ramp_delay,
};
static const struct regulator_ops bd70528_led_ops = {
--
2.20.1
Hello Axel,
On Wed, 2020-01-01 at 10:24 +0800, Axel Lin wrote:
> The .set_ramp_delay should be for bd70528_buck_ops only.
Indeed! Only the bucks on BD70528 can change the ramp-delay. Thank you
for fixing this! May I ask, how did you notice this prolem?
> Setting .set_ramp_delay for for bd70528_ldo_ops causes problem
> because
> BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT
> (0x1f).
> So setting ramp_delay for LDOs may change the voltage output, fix it.
>
> Fixes: 99ea37bd1e7d ("regulator: bd70528: Support ROHM BD70528
> regulator block")
> Signed-off-by: Axel Lin <[email protected]>
Acked-by: Matti Vaittinen <[email protected]>
Br,
Matti
Vaittinen, Matti <[email protected]> 於 2020年1月2日 週四 下午2:48寫道：
>
> Hello Axel,
>
> On Wed, 2020-01-01 at 10:24 +0800, Axel Lin wrote:
> > The .set_ramp_delay should be for bd70528_buck_ops only.
> Indeed! Only the bucks on BD70528 can change the ramp-delay. Thank you
> for fixing this! May I ask, how did you notice this prolem?
I just read the code.
On Thu, 2020-01-02 at 14:50 +0800, Axel Lin wrote:
> Vaittinen, Matti <[email protected]> 於 2020年1月2日 週四
> 下午2:48寫道：
> > Hello Axel,
> >
> > On Wed, 2020-01-01 at 10:24 +0800, Axel Lin wrote:
> > > The .set_ramp_delay should be for bd70528_buck_ops only.
> > Indeed! Only the bucks on BD70528 can change the ramp-delay. Thank
> > you
> > for fixing this! May I ask, how did you notice this prolem?
> I just read the code.
Impressive :) Thanks again!
--Matti
The patch
regulator: bd70528: Remove .set_ramp_delay for bd70528_ldo_ops
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.5
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 6f1ff76154b8b36033efcbf6453a71a3d28f52cd Mon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Wed, 1 Jan 2020 10:24:06 +0800
Subject: [PATCH] regulator: bd70528: Remove .set_ramp_delay for
bd70528_ldo_ops
The .set_ramp_delay should be for bd70528_buck_ops only.
Setting .set_ramp_delay for for bd70528_ldo_ops causes problem because
BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT (0x1f).
So setting ramp_delay for LDOs may change the voltage output, fix it.
Fixes: 99ea37bd1e7d ("regulator: bd70528: Support ROHM BD70528 regulator block")
Signed-off-by: Axel Lin <[email protected]>
Acked-by: Matti Vaittinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/bd70528-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/bd70528-regulator.c b/drivers/regulator/bd70528-regulator.c
index 0248a61f1006..6041839ec38c 100644
--- a/drivers/regulator/bd70528-regulator.c
+++ b/drivers/regulator/bd70528-regulator.c
@@ -101,7 +101,6 @@ static const struct regulator_ops bd70528_ldo_ops = {
.set_voltage_sel = regulator_set_voltage_sel_regmap,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
.set_voltage_time_sel = regulator_set_voltage_time_sel,
- .set_ramp_delay = bd70528_set_ramp_delay,
};
static const struct regulator_ops bd70528_led_ops = {
--
2.20.1