2020-01-03 19:20:24

by Wambui Karuga

Subject: [PATCH] drm/amd: use list_for_each_entry for list iteration.

list_for_each() can be replaced by the more concise
list_for_each_entry() here for iteration over the lists.
This change was reported by coccinelle.

Signed-off-by: Wambui Karuga <[email protected]>
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
index 64445c4cc4c2..cbcf504f73a5 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
@@ -111,17 +111,12 @@ static void init_handler_common_data(struct amdgpu_dm_irq_handler_data *hcd,
*/
static void dm_irq_work_func(struct work_struct *work)
{
- struct list_head *entry;
struct irq_list_head *irq_list_head =
container_of(work, struct irq_list_head, work);
struct list_head *handler_list = &irq_list_head->head;
struct amdgpu_dm_irq_handler_data *handler_data;

- list_for_each(entry, handler_list) {
- handler_data = list_entry(entry,
- struct amdgpu_dm_irq_handler_data,
- list);
-
+ list_for_each_entry(handler_data, handler_list, list) {
DRM_DEBUG_KMS("DM_IRQ: work_func: for dal_src=%d\n",
handler_data->irq_source);

@@ -528,19 +523,13 @@ static void amdgpu_dm_irq_immediate_work(struct amdgpu_device *adev,
enum dc_irq_source irq_source)
{
struct amdgpu_dm_irq_handler_data *handler_data;
- struct list_head *entry;
unsigned long irq_table_flags;

DM_IRQ_TABLE_LOCK(adev, irq_table_flags);

- list_for_each(
- entry,
- &adev->dm.irq_handler_list_high_tab[irq_source]) {
-
- handler_data = list_entry(entry,
- struct amdgpu_dm_irq_handler_data,
- list);
-
+ list_for_each_entry(handler_data,
+ &adev->dm.irq_handler_list_high_tab[irq_source],
+ list) {
/* Call a subcomponent which registered for immediate
* interrupt notification */
handler_data->handler(handler_data->handler_arg);
--
2.17.1

2020-01-06 23:07:40

by Alex Deucher

Subject: Re: [PATCH] drm/amd: use list_for_each_entry for list iteration.

On Fri, Jan 3, 2020 at 2:34 PM Wambui Karuga <[email protected]> wrote:
>
> list_for_each() can be replaced by the more concise
> list_for_each_entry() here for iteration over the lists.
> This change was reported by coccinelle.
>
> Signed-off-by: Wambui Karuga <[email protected]>

Applied. Thanks!

Alex

> ---
> .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> index 64445c4cc4c2..cbcf504f73a5 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> @@ -111,17 +111,12 @@ static void init_handler_common_data(struct amdgpu_dm_irq_handler_data *hcd,
> */
> static void dm_irq_work_func(struct work_struct *work)
> {
> - struct list_head *entry;
> struct irq_list_head *irq_list_head =
> container_of(work, struct irq_list_head, work);
> struct list_head *handler_list = &irq_list_head->head;
> struct amdgpu_dm_irq_handler_data *handler_data;
>
> - list_for_each(entry, handler_list) {
> - handler_data = list_entry(entry,
> - struct amdgpu_dm_irq_handler_data,
> - list);
> -
> + list_for_each_entry(handler_data, handler_list, list) {
> DRM_DEBUG_KMS("DM_IRQ: work_func: for dal_src=%d\n",
> handler_data->irq_source);
>
> @@ -528,19 +523,13 @@ static void amdgpu_dm_irq_immediate_work(struct amdgpu_device *adev,
> enum dc_irq_source irq_source)
> {
> struct amdgpu_dm_irq_handler_data *handler_data;
> - struct list_head *entry;
> unsigned long irq_table_flags;
>
> DM_IRQ_TABLE_LOCK(adev, irq_table_flags);
>
> - list_for_each(
> - entry,
> - &adev->dm.irq_handler_list_high_tab[irq_source]) {
> -
> - handler_data = list_entry(entry,
> - struct amdgpu_dm_irq_handler_data,
> - list);
> -
> + list_for_each_entry(handler_data,
> + &adev->dm.irq_handler_list_high_tab[irq_source],
> + list) {
> /* Call a subcomponent which registered for immediate
> * interrupt notification */
> handler_data->handler(handler_data->handler_arg);
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx