2019-12-20 18:54:09

by Kuldeep Singh

Subject: [PATCH] arm64: dts: ls208xa: Update qspi node properties for LS2088ARDB

LS2088ADB has one spansion flash s25fs512s of size 64M.

Add qspi dts entry for the board using compatibles as "jedec,spi-nor" to
probe flash successfully. Also, align properties with other board dts
properties.

Use dt-bindings constants in interrupts instead of using numbers.

Signed-off-by: Kuldeep Singh <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi | 10 +++++++++-
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ++--
2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
index 6fd7f63085c9..d0d670227ae2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
@@ -108,7 +108,15 @@
};

&qspi {
- status = "disabled";
+ status = "okay";
+
+ s25fs512s0: flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ spi-max-frequency = <50000000>;
+ reg = <0>;
+ };
};

&sata0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 8b2fd278844b..f96d06da96be 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -618,16 +618,16 @@
};

qspi: spi@20c0000 {
- status = "disabled";
compatible = "fsl,ls2080a-qspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x20c0000 0x0 0x10000>,
<0x0 0x20000000 0x0 0x10000000>;
reg-names = "QuadSPI", "QuadSPI-memory";
- interrupts = <0 25 0x4>; /* Level high type */
+ interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen 4 3>, <&clockgen 4 3>;
clock-names = "qspi_en", "qspi";
+ status = "disabled";
};

pcie1: pcie@3400000 {
--
2.17.1

2020-01-09 07:33:50

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: ls208xa: Update qspi node properties for LS2088ARDB

On Sat, Dec 21, 2019 at 12:22:34AM +0530, Kuldeep Singh wrote:
> LS2088ADB has one spansion flash s25fs512s of size 64M.
>
> Add qspi dts entry for the board using compatibles as "jedec,spi-nor" to
> probe flash successfully. Also, align properties with other board dts
> properties.
>
> Use dt-bindings constants in interrupts instead of using numbers.
>
> Signed-off-by: Kuldeep Singh <[email protected]>

Applied, thanks.