2020-01-10 01:31:25

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] phy: ti: j721e-wiz: Fix return value check in wiz_probe()

In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: b46f531313a4 ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/phy/ti/phy-j721e-wiz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index b86ebdd68302..b9654ec89662 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -762,7 +762,7 @@ static int wiz_probe(struct platform_device *pdev)
}

base = devm_ioremap(dev, res.start, resource_size(&res));
- if (IS_ERR(base))
+ if (!base)
goto err_addr_to_resource;

regmap = devm_regmap_init_mmio(dev, base, &wiz_regmap_config);