2020-01-21 08:52:07

by Alex Shi

[permalink] [raw]
Subject: [PATCH] net/hsr: remove seq_nr_after_or_eq

It's never used after introduced. So maybe better to remove.

Signed-off-by: Alex Shi <[email protected]>
Cc: Arvid Brodin <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
net/hsr/hsr_framereg.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
index 27dc65d7de67..364ea2cc028e 100644
--- a/net/hsr/hsr_framereg.c
+++ b/net/hsr/hsr_framereg.c
@@ -35,7 +35,6 @@ static bool seq_nr_after(u16 a, u16 b)
}

#define seq_nr_before(a, b) seq_nr_after((b), (a))
-#define seq_nr_after_or_eq(a, b) (!seq_nr_before((a), (b)))
#define seq_nr_before_or_eq(a, b) (!seq_nr_after((a), (b)))

bool hsr_addr_is_self(struct hsr_priv *hsr, unsigned char *addr)
--
1.8.3.1


2020-01-21 11:06:50

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net/hsr: remove seq_nr_after_or_eq

From: Alex Shi <[email protected]>
Date: Tue, 21 Jan 2020 16:49:53 +0800

> It's never used after introduced. So maybe better to remove.
>
> Signed-off-by: Alex Shi <[email protected]>

Applied to net-next