2020-01-21 10:35:52

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 00/20] ARM: Drop unneeded select of multi-platform selected options

Hi all,

This patch series drops select statements from the various
platform-specific Kconfig files, for symbols that are already selected
by the various multi-platform related config options
(ARCH_MULTIPLATFORM, ARCH_MULTI_V*, and ARM_SINGLE_ARMV7M).
This makes it easier to e.g. identify platforms that are not yet part of
multi-platform builds, but already use some multi-platform features
(e.g. "COMMON_CLK" is used by multi-platform + s3c24xx).

All patches in this series are independent of each other.

This has been tested by running "make oldconfig" on .config files
expanded before from all defconfig files, which triggered no changes.

Thanks!

Geert Uytterhoeven (20):
ARM: actions: Drop unneeded select of COMMON_CLK
ARM: alpine: Drop unneeded select of HAVE_SMP
ARM: asm9260: Drop unneeded select of GENERIC_CLOCKEVENTS
ARM: aspeed: Drop unneeded select of HAVE_SMP
ARM: at91: Drop unneeded select of COMMON_CLK
ARM: bcm: Drop unneeded select of PCI_DOMAINS_GENERIC, HAVE_SMP,
TIMER_OF
ARM: berlin: Drop unneeded select of HAVE_SMP
ARM: clps711x: Drop unneeded select of multi-platform selected options
ARM: davinci: Drop unneeded select of TIMER_OF
ARM: exynos: Drop unneeded select of MIGHT_HAVE_CACHE_L2X0
ARM: integrator: Drop unneeded select of SPARSE_IRQ
ARM: meson: Drop unneeded select of COMMON_CLK
ARM: mmp: Drop unneeded select of COMMON_CLK
ARM: mvebu: Drop unneeded select of HAVE_SMP
ARM: omap2plus: Drop unneeded select of MIGHT_HAVE_CACHE_L2X0
ARM: orion5x: Drop unneeded select of PCI_DOMAINS_GENERIC
ARM: prima2: Drop unneeded select of HAVE_SMP
ARM: realview: Drop unneeded select of multi-platform features
ARM: s3c64xx: Drop unneeded select of TIMER_OF
ARM: socfpga: Drop unneeded select of PCI_DOMAINS_GENERIC

arch/arm/mach-actions/Kconfig | 1 -
arch/arm/mach-alpine/Kconfig | 1 -
arch/arm/mach-asm9260/Kconfig | 1 -
arch/arm/mach-aspeed/Kconfig | 1 -
arch/arm/mach-at91/Kconfig | 1 -
arch/arm/mach-bcm/Kconfig | 8 --------
arch/arm/mach-berlin/Kconfig | 1 -
arch/arm/mach-clps711x/Kconfig | 5 -----
arch/arm/mach-davinci/Kconfig | 1 -
arch/arm/mach-exynos/Kconfig | 1 -
arch/arm/mach-integrator/Kconfig | 1 -
arch/arm/mach-meson/Kconfig | 1 -
arch/arm/mach-mmp/Kconfig | 1 -
arch/arm/mach-mvebu/Kconfig | 3 ---
arch/arm/mach-omap2/Kconfig | 1 -
arch/arm/mach-orion5x/Kconfig | 2 --
arch/arm/mach-prima2/Kconfig | 1 -
arch/arm/mach-realview/Kconfig | 8 --------
arch/arm/mach-s3c64xx/Kconfig | 1 -
arch/arm/mach-socfpga/Kconfig | 1 -
20 files changed, 41 deletions(-)

--
2.17.1

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2020-01-21 10:40:02

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 01/20] ARM: actions: Drop unneeded select of COMMON_CLK

Support for Actions Semi SoCs depends on ARCH_MULTI_V7, and thus on
ARCH_MULTIPLATFORM.
As the latter selects COMMON_CLK, there is no need for ARCH_ACTIONS to
select COMMON_CLK.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Andreas Färber <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
---
All patches in this series are independent of each other.
Cover letter at https://lore.kernel.org/r/[email protected]

arch/arm/mach-actions/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-actions/Kconfig b/arch/arm/mach-actions/Kconfig
index b5e0ac965ec0dd10..00fb4babccdd991b 100644
--- a/arch/arm/mach-actions/Kconfig
+++ b/arch/arm/mach-actions/Kconfig
@@ -7,7 +7,6 @@ menuconfig ARCH_ACTIONS
select ARM_GLOBAL_TIMER
select CACHE_L2X0
select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
- select COMMON_CLK
select GENERIC_IRQ_CHIP
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
--
2.17.1

2020-01-21 10:40:03

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 06/20] ARM: bcm: Drop unneeded select of PCI_DOMAINS_GENERIC, HAVE_SMP, TIMER_OF

Support for Broadcom SoCs depends on ARCH_MULTI_V6_V7, and thus on
ARCH_MULTIPLATFORM, which selects PCI_DOMAINS_GENERIC and TIMER_OF.
Support for the various Broadcom IPROC architected SoCs depends on
ARCH_MULTI_V7, which selects HAVE_SMP.
Hence there is no need for the Broadcom-specific symbols to select any
of them.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: [email protected]
---
All patches in this series are independent of each other.
Cover letter at https://lore.kernel.org/r/[email protected]

arch/arm/mach-bcm/Kconfig | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index fcfe2a0e805896e9..6aa938b949db2fec 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -20,7 +20,6 @@ config ARCH_BCM_IPROC
select GPIOLIB
select ARM_AMBA
select PINCTRL
- select PCI_DOMAINS_GENERIC if PCI
help
This enables support for systems based on Broadcom IPROC architected SoCs.
The IPROC complex contains one or more ARM CPUs along with common
@@ -54,7 +53,6 @@ config ARCH_BCM_NSP
select ARM_ERRATA_754322
select ARM_ERRATA_775420
select ARM_ERRATA_764369 if SMP
- select HAVE_SMP
select THERMAL
select THERMAL_OF
help
@@ -73,7 +71,6 @@ config ARCH_BCM_5301X
select ARM_ERRATA_754322
select ARM_ERRATA_775420
select ARM_ERRATA_764369 if SMP
- select HAVE_SMP

help
Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores.
@@ -109,7 +106,6 @@ config ARCH_BCM_281XX
bool "Broadcom BCM281XX SoC family"
depends on ARCH_MULTI_V7
select ARCH_BCM_MOBILE
- select HAVE_SMP
help
Enable support for the BCM281XX family, which includes
BCM11130, BCM11140, BCM11351, BCM28145 and BCM28155
@@ -119,7 +115,6 @@ config ARCH_BCM_21664
bool "Broadcom BCM21664 SoC family"
depends on ARCH_MULTI_V7
select ARCH_BCM_MOBILE
- select HAVE_SMP
help
Enable support for the BCM21664 family, which includes
BCM21663 and BCM21664 variants.
@@ -128,7 +123,6 @@ config ARCH_BCM_23550
bool "Broadcom BCM23550 SoC"
depends on ARCH_MULTI_V7
select ARCH_BCM_MOBILE
- select HAVE_SMP
help
Enable support for the BCM23550.

@@ -165,7 +159,6 @@ config ARCH_BCM2835
select ZONE_DMA if ARCH_MULTI_V7
select ARM_TIMER_SP804
select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7
- select TIMER_OF
select BCM2835_TIMER
select PINCTRL
select PINCTRL_BCM2835
@@ -201,7 +194,6 @@ config ARCH_BCM_63XX
select HAVE_ARM_ARCH_TIMER
select HAVE_ARM_TWD if SMP
select HAVE_ARM_SCU if SMP
- select HAVE_SMP
help
This enables support for systems based on Broadcom DSL SoCs.
It currently supports the 'BCM63XX' ARM-based family, which includes
--
2.17.1

2020-01-21 10:40:07

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 12/20] ARM: meson: Drop unneeded select of COMMON_CLK

Support for Amlogic Meson SoCs depends on ARCH_MULTI_V7, and thus on
ARCH_MULTIPLATFORM.
As the latter selects COMMON_CLK, there is no need for ARCH_MESON to
select COMMON_CLK.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: [email protected]
---
All patches in this series are independent of each other.
Cover letter at https://lore.kernel.org/r/[email protected]

arch/arm/mach-meson/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
index 01f0f4b765e00c98..75034fe197e3be0d 100644
--- a/arch/arm/mach-meson/Kconfig
+++ b/arch/arm/mach-meson/Kconfig
@@ -9,7 +9,6 @@ menuconfig ARCH_MESON
select CACHE_L2X0
select PINCTRL
select PINCTRL_MESON
- select COMMON_CLK
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP

--
2.17.1

2020-01-21 10:41:05

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 05/20] ARM: at91: Drop unneeded select of COMMON_CLK

Support for AT91/Microchip SoCs depends on ARCH_MULTIPLATFORM or
ARM_SINGLE_ARMV7M, which both select COMMON_CLK.
Hence there is no need for COMMON_CLK_AT91 to select COMMON_CLK.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Nicolas Ferre <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: Ludovic Desroches <[email protected]>
---
All patches in this series are independent of each other.
Cover letter at https://lore.kernel.org/r/[email protected]

arch/arm/mach-at91/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index af41725fcc72d1a4..dc7ed483306348c8 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -136,7 +136,6 @@ config HAVE_AT91_USB_CLK

config COMMON_CLK_AT91
bool
- select COMMON_CLK
select MFD_SYSCON

config HAVE_AT91_SMD
--
2.17.1

2020-01-21 10:41:05

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 03/20] ARM: asm9260: Drop unneeded select of GENERIC_CLOCKEVENTS

Support for the Alphascale ASM9260 platform depends on ARCH_MULTI_V5,
and thus on ARCH_MULTIPLATFORM.
As the latter selects GENERIC_CLOCKEVENTS, there is no need for
MACH_ASM9260 to select GENERIC_CLOCKEVENTS.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Oleksij Rempel <[email protected]>
---
All patches in this series are independent of each other.
Cover letter at https://lore.kernel.org/r/[email protected]

arch/arm/mach-asm9260/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-asm9260/Kconfig b/arch/arm/mach-asm9260/Kconfig
index e42dbaa53bc61b20..a2e1d0aaf2529aa5 100644
--- a/arch/arm/mach-asm9260/Kconfig
+++ b/arch/arm/mach-asm9260/Kconfig
@@ -4,6 +4,5 @@ config MACH_ASM9260
depends on ARCH_MULTI_V5
select CPU_ARM926T
select ASM9260_TIMER
- select GENERIC_CLOCKEVENTS
help
Support for Alphascale ASM9260 based platform.
--
2.17.1

2020-01-21 15:09:32

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 00/20] ARM: Drop unneeded select of multi-platform selected options

On Tue, Jan 21, 2020 at 11:34 AM Geert Uytterhoeven
<[email protected]> wrote:
>
> Hi all,
>
> This patch series drops select statements from the various
> platform-specific Kconfig files, for symbols that are already selected
> by the various multi-platform related config options
> (ARCH_MULTIPLATFORM, ARCH_MULTI_V*, and ARM_SINGLE_ARMV7M).
> This makes it easier to e.g. identify platforms that are not yet part of
> multi-platform builds, but already use some multi-platform features
> (e.g. "COMMON_CLK" is used by multi-platform + s3c24xx).
>
> All patches in this series are independent of each other.
>
> This has been tested by running "make oldconfig" on .config files
> expanded before from all defconfig files, which triggered no changes.

Nice cleanup!

Acked-by: Arnd Bergmann <[email protected]>

2020-01-21 22:14:00

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH 12/20] ARM: meson: Drop unneeded select of COMMON_CLK

On Tue, Jan 21, 2020 at 12:47 PM Geert Uytterhoeven
<[email protected]> wrote:
>
> Support for Amlogic Meson SoCs depends on ARCH_MULTI_V7, and thus on
> ARCH_MULTIPLATFORM.
> As the latter selects COMMON_CLK, there is no need for ARCH_MESON to
> select COMMON_CLK.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Martin Blumenstingl <[email protected]>

> Cc: Kevin Hilman <[email protected]>
> Cc: [email protected]
I assume that Kevin should take this through the linux-amlogic tree
(instead of someone else applying the whole series directly to the
arm-soc tree)?


Martin

2020-01-22 07:36:14

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 12/20] ARM: meson: Drop unneeded select of COMMON_CLK

Hi Martin,

On Tue, Jan 21, 2020 at 11:11 PM Martin Blumenstingl
<[email protected]> wrote:
> On Tue, Jan 21, 2020 at 12:47 PM Geert Uytterhoeven
> <[email protected]> wrote:
> > Support for Amlogic Meson SoCs depends on ARCH_MULTI_V7, and thus on
> > ARCH_MULTIPLATFORM.
> > As the latter selects COMMON_CLK, there is no need for ARCH_MESON to
> > select COMMON_CLK.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> Acked-by: Martin Blumenstingl <[email protected]>

Thanks!

> > Cc: Kevin Hilman <[email protected]>
> > Cc: [email protected]
> I assume that Kevin should take this through the linux-amlogic tree
> (instead of someone else applying the whole series directly to the
> arm-soc tree)?

Yes, that's the way to reduce the risk of conflicts.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-01-22 20:36:43

by Andreas Färber

[permalink] [raw]
Subject: Re: [PATCH 01/20] ARM: actions: Drop unneeded select of COMMON_CLK

Am 21.01.20 um 11:37 schrieb Geert Uytterhoeven:
> Support for Actions Semi SoCs depends on ARCH_MULTI_V7, and thus on
> ARCH_MULTIPLATFORM.
> As the latter selects COMMON_CLK, there is no need for ARCH_ACTIONS to
> select COMMON_CLK.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Cc: Andreas Färber <[email protected]>

Reviewed-by: Andreas Färber <[email protected]>

> Cc: Manivannan Sadhasivam <[email protected]>
> ---
> All patches in this series are independent of each other.
> Cover letter at https://lore.kernel.org/r/[email protected]
>
> arch/arm/mach-actions/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-actions/Kconfig b/arch/arm/mach-actions/Kconfig
> index b5e0ac965ec0dd10..00fb4babccdd991b 100644
> --- a/arch/arm/mach-actions/Kconfig
> +++ b/arch/arm/mach-actions/Kconfig
> @@ -7,7 +7,6 @@ menuconfig ARCH_ACTIONS
> select ARM_GLOBAL_TIMER
> select CACHE_L2X0
> select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> - select COMMON_CLK
> select GENERIC_IRQ_CHIP
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP

Thanks,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

2020-01-28 23:24:28

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 06/20] ARM: bcm: Drop unneeded select of PCI_DOMAINS_GENERIC, HAVE_SMP, TIMER_OF

On Tue, 21 Jan 2020 11:37:08 +0100, Geert Uytterhoeven <[email protected]> wrote:
> Support for Broadcom SoCs depends on ARCH_MULTI_V6_V7, and thus on
> ARCH_MULTIPLATFORM, which selects PCI_DOMAINS_GENERIC and TIMER_OF.
> Support for the various Broadcom IPROC architected SoCs depends on
> ARCH_MULTI_V7, which selects HAVE_SMP.
> Hence there is no need for the Broadcom-specific symbols to select any
> of them.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Cc: Florian Fainelli <[email protected]>
> Cc: Ray Jui <[email protected]>
> Cc: Scott Branden <[email protected]>
> Cc: [email protected]
> ---

Applied to soc/next, thanks!
--
Florian

2020-02-10 16:58:10

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH 05/20] ARM: at91: Drop unneeded select of COMMON_CLK

On 21/01/2020 11:37:07+0100, Geert Uytterhoeven wrote:
> Support for AT91/Microchip SoCs depends on ARCH_MULTIPLATFORM or
> ARM_SINGLE_ARMV7M, which both select COMMON_CLK.
> Hence there is no need for COMMON_CLK_AT91 to select COMMON_CLK.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Cc: Nicolas Ferre <[email protected]>
> Cc: Alexandre Belloni <[email protected]>
> Cc: Ludovic Desroches <[email protected]>
> ---
> All patches in this series are independent of each other.
> Cover letter at https://lore.kernel.org/r/[email protected]
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com