2020-02-02 01:50:18

by Hridya Valsaraju

Subject: [PATCH] selinux: Fix typo in filesystem name

Correct the filesystem name to "binder" to enable
genfscon per-file labelling for binderfs.

Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
Signed-off-by: Hridya Valsaraju <[email protected]>
---

Hello,

I seem to have made the typo/mistake during a rebase. Sorry about that
:(

Thanks,
Hridya

security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 89fe3a805129..d67a80b0d8a8 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,

if (!strcmp(sb->s_type->name, "debugfs") ||
!strcmp(sb->s_type->name, "tracefs") ||
- !strcmp(sb->s_type->name, "binderfs") ||
+ !strcmp(sb->s_type->name, "binder") ||
!strcmp(sb->s_type->name, "pstore"))
sbsec->flags |= SE_SBGENFS;

--
2.25.0.341.g760bfbb309-goog

2020-02-03 15:34:18

by Stephen Smalley

Subject: Re: [PATCH] selinux: Fix typo in filesystem name

On 2/1/20 8:46 PM, Hridya Valsaraju wrote:
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <[email protected]>

Acked-by: Stephen Smalley <[email protected]>

> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
> if (!strcmp(sb->s_type->name, "debugfs") ||
> !strcmp(sb->s_type->name, "tracefs") ||
> - !strcmp(sb->s_type->name, "binderfs") ||
> + !strcmp(sb->s_type->name, "binder") ||
> !strcmp(sb->s_type->name, "pstore"))
> sbsec->flags |= SE_SBGENFS;
>
>

2020-02-05 23:31:18

by Paul Moore

Subject: Re: [PATCH] selinux: Fix typo in filesystem name

On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <[email protected]> wrote:
>
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <[email protected]>
> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Ooops :/

Thanks for the fix. I've merged this into selinux/stable-5.6, but due
to some personal scheduling issues on my end I'm going to refrain from
sending this to Linus until next week.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
> if (!strcmp(sb->s_type->name, "debugfs") ||
> !strcmp(sb->s_type->name, "tracefs") ||
> - !strcmp(sb->s_type->name, "binderfs") ||
> + !strcmp(sb->s_type->name, "binder") ||
> !strcmp(sb->s_type->name, "pstore"))
> sbsec->flags |= SE_SBGENFS;
>
> --
> 2.25.0.341.g760bfbb309-goog

--
paul moore
http://www.paul-moore.com

2020-02-06 00:06:56

by Hridya Valsaraju

Subject: Re: [PATCH] selinux: Fix typo in filesystem name

On Wed, Feb 5, 2020 at 3:28 PM Paul Moore <[email protected]> wrote:
>
> On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <[email protected]> wrote:
> >
> > Correct the filesystem name to "binder" to enable
> > genfscon per-file labelling for binderfs.
> >
> > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> > Signed-off-by: Hridya Valsaraju <[email protected]>
> > ---
> >
> > Hello,
> >
> > I seem to have made the typo/mistake during a rebase. Sorry about that
> > :(
> >
> > Thanks,
> > Hridya
> >
> > security/selinux/hooks.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ooops :/
>
> Thanks for the fix. I've merged this into selinux/stable-5.6, but due
> to some personal scheduling issues on my end I'm going to refrain from
> sending this to Linus until next week.

Thank you Paul and Stephen!

Regards,
Hridya

>
> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> > index 89fe3a805129..d67a80b0d8a8 100644
> > --- a/security/selinux/hooks.c
> > +++ b/security/selinux/hooks.c
> > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
> >
> > if (!strcmp(sb->s_type->name, "debugfs") ||
> > !strcmp(sb->s_type->name, "tracefs") ||
> > - !strcmp(sb->s_type->name, "binderfs") ||
> > + !strcmp(sb->s_type->name, "binder") ||
> > !strcmp(sb->s_type->name, "pstore"))
> > sbsec->flags |= SE_SBGENFS;
> >
> > --
> > 2.25.0.341.g760bfbb309-goog
>
> --
> paul moore
> http://www.paul-moore.com