2020-02-04 20:18:16

by Tomas Winkler

Subject: [PATCH] mfd: constify properties in mfd_cell

Constify 'struct property_entry *properties' in
mfd_cell and platform_device. It is always passed
around as a pointer const struct.

Signed-off-by: Tomas Winkler <[email protected]>
---
include/linux/mfd/core.h | 2 +-
include/linux/platform_device.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index d01d1299e49d..7e5ac3c00891 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -70,7 +70,7 @@ struct mfd_cell {
size_t pdata_size;

/* device properties passed to the sub devices drivers */
- struct property_entry *properties;
+ const struct property_entry *properties;

/*
* Device Tree compatible string
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 276a03c24691..8e83c6ff140d 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -89,7 +89,7 @@ struct platform_device_info {
size_t size_data;
u64 dma_mask;

- struct property_entry *properties;
+ const struct property_entry *properties;
};
extern struct platform_device *platform_device_register_full(
const struct platform_device_info *pdevinfo);
--
2.21.1

2020-02-04 21:23:37

by Andy Shevchenko

Subject: Re: [PATCH] mfd: constify properties in mfd_cell

On Tue, Feb 4, 2020 at 10:18 PM Tomas Winkler <[email protected]> wrote:
>
> Constify 'struct property_entry *properties' in
> mfd_cell and platform_device. It is always passed
> around as a pointer const struct.
>

After

commit 277036f05be242540b7bfe75f226107d04f51b06
Author: Jan Kiszka <[email protected]>
Date: Fri Jun 2 07:43:27 2017 +0200

platform: Accept const properties

this one makes sense.

Reviewed-by: Andy Shevchenko <[email protected]>

Does intel-lpss* compile with this change?

> Signed-off-by: Tomas Winkler <[email protected]>
> ---
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index d01d1299e49d..7e5ac3c00891 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -70,7 +70,7 @@ struct mfd_cell {
> size_t pdata_size;
>
> /* device properties passed to the sub devices drivers */
> - struct property_entry *properties;
> + const struct property_entry *properties;
>
> /*
> * Device Tree compatible string
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..8e83c6ff140d 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -89,7 +89,7 @@ struct platform_device_info {
> size_t size_data;
> u64 dma_mask;
>
> - struct property_entry *properties;
> + const struct property_entry *properties;
> };
> extern struct platform_device *platform_device_register_full(
> const struct platform_device_info *pdevinfo);
> --
> 2.21.1
>


--
With Best Regards,
Andy Shevchenko

2020-02-04 21:34:33

by Tomas Winkler

Subject: RE: [PATCH] mfd: constify properties in mfd_cell

>
> On Tue, Feb 4, 2020 at 10:18 PM Tomas Winkler <[email protected]>
> wrote:
> >
> > Constify 'struct property_entry *properties' in mfd_cell and
> > platform_device. It is always passed around as a pointer const struct.
> >
>
> After
>
> commit 277036f05be242540b7bfe75f226107d04f51b06
> Author: Jan Kiszka <[email protected]>
> Date: Fri Jun 2 07:43:27 2017 +0200
>
> platform: Accept const properties
>
> this one makes sense.
>
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> Does intel-lpss* compile with this change?


Yes, It does.

2020-02-04 22:50:14

by Greg Kroah-Hartman

Subject: Re: [PATCH] mfd: constify properties in mfd_cell

On Tue, Feb 04, 2020 at 10:16:51PM +0200, Tomas Winkler wrote:
> Constify 'struct property_entry *properties' in
> mfd_cell and platform_device. It is always passed
> around as a pointer const struct.
>
> Signed-off-by: Tomas Winkler <[email protected]>
> ---
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index d01d1299e49d..7e5ac3c00891 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -70,7 +70,7 @@ struct mfd_cell {
> size_t pdata_size;
>
> /* device properties passed to the sub devices drivers */
> - struct property_entry *properties;
> + const struct property_entry *properties;
>
> /*
> * Device Tree compatible string
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..8e83c6ff140d 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -89,7 +89,7 @@ struct platform_device_info {
> size_t size_data;
> u64 dma_mask;
>
> - struct property_entry *properties;
> + const struct property_entry *properties;
> };
> extern struct platform_device *platform_device_register_full(
> const struct platform_device_info *pdevinfo);
> --
> 2.21.1
>

This really is two different patches, can you split and resend?

thanks,

gre gk-h