2020-02-18 13:01:42

by Pradeep P V K

[permalink] [raw]
Subject: [RFC v4 2/2] dt-bindings: mmc: sdhci-msm: Add interconnect BW scaling strings

Add interconnect bandwidth scaling supported strings for qcom-sdhci
controller.

Signed-off-by: Pradeep P V K <[email protected]>
---

changes from RFC v3 -> v4:
- No changes.

Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 7ee639b..cbe97b8 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -40,6 +40,21 @@ Required properties:
"cal" - reference clock for RCLK delay calibration (optional)
"sleep" - sleep clock for RCLK delay calibration (optional)

+Optional Properties:
+* Following bus parameters are required for interconnect bandwidth scaling:
+- interconnects: Pairs of phandles and interconnect provider specifier
+ to denote the edge source and destination ports of
+ the interconnect path.
+
+- interconnect-names: For sdhc, we have two main paths.
+ 1. Data path : sdhc to ddr
+ 2. Config path : cpu to sdhc
+ For Data interconnect path the name supposed to be
+ is "sdhc-ddr" and for config interconnect path it is
+ "cpu-sdhc".
+ Please refer to Documentation/devicetree/bindings/
+ interconnect/ for more details.
+
Example:

sdhc_1: sdhci@f9824900 {
@@ -57,6 +72,9 @@ Example:

clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>;
clock-names = "core", "iface";
+ interconnects = <&qnoc MASTER_SDCC_ID &qnoc SLAVE_DDR_ID>,
+ <&qnoc MASTER_CPU_ID &qnoc SLAVE_SDCC_ID>;
+ interconnect-names = "sdhc-ddr","cpu-sdhc";
};

sdhc_2: sdhci@f98a4900 {
--
1.9.1


2020-02-18 21:31:51

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [RFC v4 2/2] dt-bindings: mmc: sdhci-msm: Add interconnect BW scaling strings

On Tue, 18 Feb 2020 18:30:33 +0530, Pradeep P V K wrote:
> Add interconnect bandwidth scaling supported strings for qcom-sdhci
> controller.
>
> Signed-off-by: Pradeep P V K <[email protected]>
> ---
>
> changes from RFC v3 -> v4:
> - No changes.
>
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2020-03-08 21:51:37

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [RFC v4 2/2] dt-bindings: mmc: sdhci-msm: Add interconnect BW scaling strings

On Tue 18 Feb 05:00 PST 2020, Pradeep P V K wrote:

> Add interconnect bandwidth scaling supported strings for qcom-sdhci
> controller.
>
> Signed-off-by: Pradeep P V K <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
>
> changes from RFC v3 -> v4:
> - No changes.
>
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 7ee639b..cbe97b8 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -40,6 +40,21 @@ Required properties:
> "cal" - reference clock for RCLK delay calibration (optional)
> "sleep" - sleep clock for RCLK delay calibration (optional)
>
> +Optional Properties:
> +* Following bus parameters are required for interconnect bandwidth scaling:
> +- interconnects: Pairs of phandles and interconnect provider specifier
> + to denote the edge source and destination ports of
> + the interconnect path.
> +
> +- interconnect-names: For sdhc, we have two main paths.
> + 1. Data path : sdhc to ddr
> + 2. Config path : cpu to sdhc
> + For Data interconnect path the name supposed to be
> + is "sdhc-ddr" and for config interconnect path it is
> + "cpu-sdhc".
> + Please refer to Documentation/devicetree/bindings/
> + interconnect/ for more details.
> +
> Example:
>
> sdhc_1: sdhci@f9824900 {
> @@ -57,6 +72,9 @@ Example:
>
> clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>;
> clock-names = "core", "iface";
> + interconnects = <&qnoc MASTER_SDCC_ID &qnoc SLAVE_DDR_ID>,
> + <&qnoc MASTER_CPU_ID &qnoc SLAVE_SDCC_ID>;
> + interconnect-names = "sdhc-ddr","cpu-sdhc";
> };
>
> sdhc_2: sdhci@f98a4900 {
> --
> 1.9.1
>