2020-02-19 15:13:43

by Vladimir Oltean

Subject: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB

From: Claudiu Manoil <[email protected]>

Link the switch PHY nodes to the central MDIO controller PCIe endpoint
node on LS1028A (implemented as PF3) so that PHYs are accessible via
MDIO.

Enable SGMII AN on the Felix PCS by telling PHYLINK that the VSC8514
quad PHY is capable of in-band-status.

The PHYs are used in poll mode due to an issue with the interrupt line
on current revisions of the LS1028A-RDB board.

Signed-off-by: Claudiu Manoil <[email protected]>
Signed-off-by: Alex Marginean <[email protected]>
Signed-off-by: Vladimir Oltean <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
---
Changes in v2:
None.

.../boot/dts/freescale/fsl-ls1028a-rdb.dts | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index afb55653850d..9353c00e46a7 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -194,6 +194,57 @@
status = "disabled";
};

+&enetc_mdio_pf3 {
+ /* VSC8514 QSGMII quad PHY */
+ qsgmii_phy0: ethernet-phy@10 {
+ reg = <0x10>;
+ };
+
+ qsgmii_phy1: ethernet-phy@11 {
+ reg = <0x11>;
+ };
+
+ qsgmii_phy2: ethernet-phy@12 {
+ reg = <0x12>;
+ };
+
+ qsgmii_phy3: ethernet-phy@13 {
+ reg = <0x13>;
+ };
+};
+
+&mscc_felix_port0 {
+ status = "okay";
+ label = "swp0";
+ managed = "in-band-status";
+ phy-handle = <&qsgmii_phy0>;
+ phy-mode = "qsgmii";
+};
+
+&mscc_felix_port1 {
+ status = "okay";
+ label = "swp1";
+ managed = "in-band-status";
+ phy-handle = <&qsgmii_phy1>;
+ phy-mode = "qsgmii";
+};
+
+&mscc_felix_port2 {
+ status = "okay";
+ label = "swp2";
+ managed = "in-band-status";
+ phy-handle = <&qsgmii_phy2>;
+ phy-mode = "qsgmii";
+};
+
+&mscc_felix_port3 {
+ status = "okay";
+ label = "swp3";
+ managed = "in-band-status";
+ phy-handle = <&qsgmii_phy3>;
+ phy-mode = "qsgmii";
+};
+
&sai4 {
status = "okay";
};
--
2.17.1

2020-02-22 11:42:08

by Michael Walle

Subject: Re: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB

Hi,

> Link the switch PHY nodes to the central MDIO controller PCIe endpoint
> node on LS1028A (implemented as PF3) so that PHYs are accessible via
> MDIO.
>
> Enable SGMII AN on the Felix PCS by telling PHYLINK that the VSC8514
> quad PHY is capable of in-band-status.
>
> The PHYs are used in poll mode due to an issue with the interrupt line
> on current revisions of the LS1028A-RDB board.
>
> Signed-off-by: Claudiu Manoil <[email protected]>
> Signed-off-by: Alex Marginean <[email protected]>
> Signed-off-by: Vladimir Oltean <[email protected]>
> Reviewed-by: Andrew Lunn <[email protected]>
> ---
> Changes in v2:
> None.
>
> .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index afb55653850d..9353c00e46a7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -194,6 +194,57 @@
> status = "disabled";
> };
>
> +&enetc_mdio_pf3 {
> + /* VSC8514 QSGMII quad PHY */
> + qsgmii_phy0: ethernet-phy@10 {
> + reg = <0x10>;
> + };
> +
> + qsgmii_phy1: ethernet-phy@11 {
> + reg = <0x11>;
> + };
> +
> + qsgmii_phy2: ethernet-phy@12 {
> + reg = <0x12>;
> + };
> +
> + qsgmii_phy3: ethernet-phy@13 {
> + reg = <0x13>;
> + };
> +};
> +
> +&mscc_felix_port0 {
> + status = "okay";
status should be the last property, correct?

-michael

> + label = "swp0";
> + managed = "in-band-status";
> + phy-handle = <&qsgmii_phy0>;
> + phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port1 {
> + status = "okay";
> + label = "swp1";
> + managed = "in-band-status";
> + phy-handle = <&qsgmii_phy1>;
> + phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port2 {
> + status = "okay";
> + label = "swp2";
> + managed = "in-band-status";
> + phy-handle = <&qsgmii_phy2>;
> + phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port3 {
> + status = "okay";
> + label = "swp3";
> + managed = "in-band-status";
> + phy-handle = <&qsgmii_phy3>;
> + phy-mode = "qsgmii";
> +};
> +
> &sai4 {
> status = "okay";
> };
> --
> 2.17.1

2020-02-22 12:18:28

by Vladimir Oltean

Subject: Re: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB

Hi Michael,

On Sat, 22 Feb 2020 at 13:41, Michael Walle <[email protected]> wrote:
>
> Hi,
>
> status should be the last property, correct?
>
> -michael

I know of no such convention to exist.

-Vladimir

2020-02-24 06:39:58

by Shawn Guo

Subject: Re: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB

On Sat, Feb 22, 2020 at 02:17:54PM +0200, Vladimir Oltean wrote:
> Hi Michael,
>
> On Sat, 22 Feb 2020 at 13:41, Michael Walle <[email protected]> wrote:
> >
> > Hi,
> >
> > status should be the last property, correct?
> >
> > -michael
>
> I know of no such convention to exist.

Hmm, it's a convention for DTS files that I'm looking after.

Shawn