2020-02-19 15:13:32

by Vladimir Oltean

Subject: [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE

From: Vladimir Oltean <[email protected]>

This specifier overrides the interrupt specifier with 3 cells from gic
(/interrupt-controller@6000000), but in fact ENETC is not an interrupt
controller, so the property is bogus.

Interrupts used by the children of the ENETC RCIE must use the full
3-cell specifier required by the GIC.

The issue has no functional consequence so there is no real reason to
port the patch to stable trees.

Fixes: 927d7f857542 ("arm64: dts: fsl: ls1028a: Add PCI IERC node and ENETC endpoints")
Signed-off-by: Vladimir Oltean <[email protected]>
---
Changes in v2:
None.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 0bf375ec959b..dfead691e509 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -683,7 +683,6 @@
reg = <0x01 0xf0000000 0x0 0x100000>;
#address-cells = <3>;
#size-cells = <2>;
- #interrupt-cells = <1>;
msi-parent = <&its>;
device_type = "pci";
bus-range = <0x0 0x0>;
--
2.17.1

2020-02-24 06:34:59

by Shawn Guo

Subject: Re: [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE

On Wed, Feb 19, 2020 at 05:12:55PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <[email protected]>
>
> This specifier overrides the interrupt specifier with 3 cells from gic
> (/interrupt-controller@6000000), but in fact ENETC is not an interrupt
> controller, so the property is bogus.
>
> Interrupts used by the children of the ENETC RCIE must use the full
> 3-cell specifier required by the GIC.
>
> The issue has no functional consequence so there is no real reason to
> port the patch to stable trees.
>
> Fixes: 927d7f857542 ("arm64: dts: fsl: ls1028a: Add PCI IERC node and ENETC endpoints")
> Signed-off-by: Vladimir Oltean <[email protected]>

Prefix 'arm64: dts: ls1028a: ...' should be already clear enough.

Shawn