2020-02-24 11:52:22

by Michael Walle

Subject: [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports

Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
by default") all the network ports are disabled by default. This makes
sense, but now we have to enable them explicitly in the boards. Do so
for the sl28 module.

Since we are at it. Make sure the second port is only enabled for the
variant 4 of the module. Variant 3 has only one network port.

Signed-off-by: Michael Walle <[email protected]>
---

This patch actually superseeds the following:
https://lore.kernel.org/linux-devicetree/[email protected]/

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
index f659e89face8..df212ed5bb94 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var4.dts
@@ -21,6 +21,7 @@
&enetc_port1 {
phy-handle = <&phy1>;
phy-connection-type = "rgmii-id";
+ status = "okay";

mdio {
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index d221ed471cde..e6ad2f64e64e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -35,6 +35,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ status = "okay";

mdio {
#address-cells = <1>;
--
2.20.1

2020-02-24 11:59:21

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: ls1028: sl28: explicitly enable network ports

On Mon, Feb 24, 2020 at 12:50:52PM +0100, Michael Walle wrote:
> Since commit b9213899d2b0 ("arm64: dts: ls1028a: disable all enetc ports
> by default") all the network ports are disabled by default. This makes
> sense, but now we have to enable them explicitly in the boards. Do so
> for the sl28 module.
>
> Since we are at it. Make sure the second port is only enabled for the
> variant 4 of the module. Variant 3 has only one network port.
>
> Signed-off-by: Michael Walle <[email protected]>

Applied, thanks.