2020-02-26 00:05:12

by Jolly Shah

Subject: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

From: Tejas Patel <[email protected]>

Make zynqmp_firmware driver as optional to disable it, if user don't
want to use default zynqmp firmware interface.

Signed-off-by: Tejas Patel <[email protected]>
Signed-off-by: Jolly Shah <[email protected]>
---
arch/arm64/Kconfig.platforms | 1 -
drivers/firmware/xilinx/Kconfig | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index b2b504e..563c93d 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -301,7 +301,6 @@ config ARCH_ZX

config ARCH_ZYNQMP
bool "Xilinx ZynqMP Family"
- select ZYNQMP_FIRMWARE
help
This enables support for Xilinx ZynqMP Family

diff --git a/drivers/firmware/xilinx/Kconfig b/drivers/firmware/xilinx/Kconfig
index bd33bbf..9a9bd19 100644
--- a/drivers/firmware/xilinx/Kconfig
+++ b/drivers/firmware/xilinx/Kconfig
@@ -6,6 +6,8 @@ menu "Zynq MPSoC Firmware Drivers"

config ZYNQMP_FIRMWARE
bool "Enable Xilinx Zynq MPSoC firmware interface"
+ depends on ARCH_ZYNQMP
+ default y if ARCH_ZYNQMP
select MFD_CORE
help
Firmware interface driver is used by different
--
2.7.4

2020-02-26 11:47:59

by Sudeep Holla

Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
> From: Tejas Patel <[email protected]>
>
> Make zynqmp_firmware driver as optional to disable it, if user don't
> want to use default zynqmp firmware interface.
>

This patch on it own is simple and looks fine. However I expect the
single binary to work with and without this option on the same platform.
If zynqmp_firmware is not critical, the system should continue to work
fine either way. The zynqmp_firmware driver should gracefully exit with
error(if any).

--
Regards,
Sudeep

2020-03-03 22:30:49

by Jolly Shah

Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

Hi Sudeep,

> ------Original Message------
> From: [email protected] <[email protected]>
> Sent: Wednesday, February 26, 2020 3:46AM
> To: Jolly Shah <[email protected]>
> Cc: [email protected] <[email protected]>,
[email protected] <[email protected]>, 'Greg Kh'
<[email protected]>, [email protected]
<[email protected]>, [email protected] <[email protected]>,
[email protected] <[email protected]>, [email protected]
<[email protected]>, Michal Simek <[email protected]>,
Rajan Vaja <[email protected]>, [email protected]
<[email protected]>, [email protected]
<[email protected]>, Tejas Patel <[email protected]>,
[email protected] <[email protected]>
> Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver
optional
>
> On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
>> From: Tejas Patel <[email protected]>
>>
>> Make zynqmp_firmware driver as optional to disable it, if user don't
>> want to use default zynqmp firmware interface.
>>
>
> This patch on it own is simple and looks fine. However I expect the
> single binary to work with and without this option on the same platform.
> If zynqmp_firmware is not critical, the system should continue to work
> fine either way. The zynqmp_firmware driver should gracefully exit with
> error(if any).
>

Sure. Will address it in next version.

Thanks,
Jolly Shah


> --
> Regards,
> Sudeep
>

2020-03-09 14:00:17

by Michal Simek

Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

On 26. 02. 20 1:04, Jolly Shah wrote:
> From: Tejas Patel <[email protected]>
>
> Make zynqmp_firmware driver as optional to disable it, if user don't
> want to use default zynqmp firmware interface.
>
> Signed-off-by: Tejas Patel <[email protected]>
> Signed-off-by: Jolly Shah <[email protected]>
> ---
> arch/arm64/Kconfig.platforms | 1 -
> drivers/firmware/xilinx/Kconfig | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index b2b504e..563c93d 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -301,7 +301,6 @@ config ARCH_ZX
>
> config ARCH_ZYNQMP
> bool "Xilinx ZynqMP Family"
> - select ZYNQMP_FIRMWARE
> help
> This enables support for Xilinx ZynqMP Family
>
> diff --git a/drivers/firmware/xilinx/Kconfig b/drivers/firmware/xilinx/Kconfig
> index bd33bbf..9a9bd19 100644
> --- a/drivers/firmware/xilinx/Kconfig
> +++ b/drivers/firmware/xilinx/Kconfig
> @@ -6,6 +6,8 @@ menu "Zynq MPSoC Firmware Drivers"
>
> config ZYNQMP_FIRMWARE
> bool "Enable Xilinx Zynq MPSoC firmware interface"
> + depends on ARCH_ZYNQMP
> + default y if ARCH_ZYNQMP
> select MFD_CORE
> help
> Firmware interface driver is used by different
>

Applied but with arm64: zynqmp: Prefixes.

Thanks,
Michal