IMX SCU SoCs support COMPILE_TEST that allows to compile the driver on a
different platform for development purposes.
These SoCs depend on a firmware interface that is not built on COMPILE_TEST
mode. This results in triggering the following errors at compile time (on
arm64):
aarch64-none-linux-gnu-ld:
drivers/soc/imx/soc-imx-scu.o: in function `imx_scu_soc_probe':
soc-imx-scu.c:(.text+0x24): undefined reference to `imx_scu_get_handle'
aarch64-none-linux-gnu-ld:
soc-imx-scu.c:(.text+0xac): undefined reference to `imx_scu_call_rpc'
aarch64-none-linux-gnu-ld:
soc-imx-scu.c:(.text+0xd8): undefined reference to `imx_scu_call_rpc'
linux/Makefile:1078: recipe for target 'vmlinux' failed
make[1]: *** [vmlinux] Error 1
Makefile:180: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
Enable the relevant compilation units in the Makefile when the config option
is selected to address the issue.
Cc: Shawn Guo <[email protected]>
Cc: Sascha Hauer <[email protected]>
Signed-off-by: Vincenzo Frascino <[email protected]>
---
drivers/firmware/imx/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefile
index 08bc9ddfbdfb..5604adae31d9 100644
--- a/drivers/firmware/imx/Makefile
+++ b/drivers/firmware/imx/Makefile
@@ -2,3 +2,5 @@
obj-$(CONFIG_IMX_DSP) += imx-dsp.o
obj-$(CONFIG_IMX_SCU) += imx-scu.o misc.o imx-scu-irq.o
obj-$(CONFIG_IMX_SCU_PD) += scu-pd.o
+
+obj-$(CONFIG_COMPILE_TEST) += imx-scu.o misc.o imx-scu-irq.o
--
2.25.1
Hi Vincenzo,
I love your patch! Yet something to improve:
[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on v5.6-rc4 next-20200306]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vincenzo-Frascino/drivers-soc-Fix-COMPILE_TEST-for-IMX-SCU/20200307-033704
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: i386-randconfig-e003-20200305 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <[email protected]>
All errors (new ones prefixed by >>):
ld: drivers/firmware/imx/imx-scu.o: in function `imx_scu_call_rpc':
>> imx-scu.c:(.text+0xbb): undefined reference to `mbox_send_message'
ld: drivers/firmware/imx/imx-scu.o: in function `imx_scu_probe':
>> imx-scu.c:(.text+0x356): undefined reference to `mbox_request_channel_byname'
ld: drivers/firmware/imx/imx-scu-irq.o: in function `imx_scu_enable_general_irq_channel':
>> imx-scu-irq.c:(.text+0x22b): undefined reference to `mbox_request_channel_byname'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Hi Vincenzo,
I love your patch! Yet something to improve:
[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on v5.6-rc4 next-20200306]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vincenzo-Frascino/drivers-soc-Fix-COMPILE_TEST-for-IMX-SCU/20200307-033704
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: x86_64-randconfig-c003-20200307 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <[email protected]>
All errors (new ones prefixed by >>):
ld: drivers/firmware/imx/imx-scu.o: in function `imx_scu_call_rpc':
>> (.text+0x149): undefined reference to `mbox_send_message'
ld: drivers/firmware/imx/imx-scu.o: in function `imx_scu_probe':
imx-scu.c:(.text+0x6ec): undefined reference to `mbox_request_channel_byname'
ld: drivers/firmware/imx/imx-scu-irq.o: in function `imx_scu_enable_general_irq_channel':
>> (.text+0x31f): undefined reference to `mbox_request_channel_byname'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Fri, Mar 06, 2020 at 11:31:19AM +0000, Vincenzo Frascino wrote:
> IMX SCU SoCs support COMPILE_TEST that allows to compile the driver on a
> different platform for development purposes.
> These SoCs depend on a firmware interface that is not built on COMPILE_TEST
> mode. This results in triggering the following errors at compile time (on
> arm64):
>
> aarch64-none-linux-gnu-ld:
> drivers/soc/imx/soc-imx-scu.o: in function `imx_scu_soc_probe':
> soc-imx-scu.c:(.text+0x24): undefined reference to `imx_scu_get_handle'
> aarch64-none-linux-gnu-ld:
> soc-imx-scu.c:(.text+0xac): undefined reference to `imx_scu_call_rpc'
> aarch64-none-linux-gnu-ld:
> soc-imx-scu.c:(.text+0xd8): undefined reference to `imx_scu_call_rpc'
> linux/Makefile:1078: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
> Makefile:180: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
>
> Enable the relevant compilation units in the Makefile when the config option
> is selected to address the issue.
>
> Cc: Shawn Guo <[email protected]>
> Cc: Sascha Hauer <[email protected]>
> Signed-off-by: Vincenzo Frascino <[email protected]>
Thanks for the patch. But we already queued Peng's version [1].
Shawn
[1] https://www.spinics.net/lists/arm-kernel/msg787548.html