2020-03-09 13:01:10

by Lubomir Rintel

Subject: [PATCH 2/2] USB: EHCI: ehci-mv: use a unique bus name

In case there are multiple Marvell EHCI blocks in system, we need a
different bus name for each one. Otherwise debugfs gets mildly upset about
a directory name in usb/ehci:

debugfs: Directory 'mv ehci' with parent 'ehci' already present!

Signed-off-by: Lubomir Rintel <[email protected]>
---
drivers/usb/host/ehci-mv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index ddb668963955f..1300c457d9ed6 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -115,7 +115,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
if (usb_disabled())
return -ENODEV;

- hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, "mv ehci");
+ hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, dev_name(&pdev->dev));
if (!hcd)
return -ENOMEM;

--
2.25.1

2020-03-10 14:05:42

by Alan Stern

Subject: Re: [PATCH 2/2] USB: EHCI: ehci-mv: use a unique bus name

On Mon, 9 Mar 2020, Lubomir Rintel wrote:

> In case there are multiple Marvell EHCI blocks in system, we need a
> different bus name for each one. Otherwise debugfs gets mildly upset about
> a directory name in usb/ehci:
>
> debugfs: Directory 'mv ehci' with parent 'ehci' already present!
>
> Signed-off-by: Lubomir Rintel <[email protected]>

Acked-by: Alan Stern <[email protected]>

> ---
> drivers/usb/host/ehci-mv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index ddb668963955f..1300c457d9ed6 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -115,7 +115,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
> if (usb_disabled())
> return -ENODEV;
>
> - hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, "mv ehci");
> + hcd = usb_create_hcd(&ehci_platform_hc_driver, &pdev->dev, dev_name(&pdev->dev));
> if (!hcd)
> return -ENOMEM;
>
>