2020-03-21 11:23:11

by Lad, Prabhakar

[permalink] [raw]
Subject: [PATCH] misc: pci_endpoint_test: remove duplicate macro PCI_ENDPOINT_TEST_STATUS

PCI_ENDPOINT_TEST_STATUS is already defined in pci_endpoint_test.c along
with the status bits, so this patch drops duplicate definition.

Signed-off-by: Lad Prabhakar <[email protected]>
---
This patch applies on top of pci/endpoint branch [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git

drivers/misc/pci_endpoint_test.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index b536ca4b14ca..a1bb94902b5a 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -53,7 +53,6 @@
#define STATUS_SRC_ADDR_INVALID BIT(7)
#define STATUS_DST_ADDR_INVALID BIT(8)

-#define PCI_ENDPOINT_TEST_STATUS 0x8
#define PCI_ENDPOINT_TEST_LOWER_SRC_ADDR 0x0c
#define PCI_ENDPOINT_TEST_UPPER_SRC_ADDR 0x10

--
2.20.1


2020-03-26 17:52:26

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] misc: pci_endpoint_test: remove duplicate macro PCI_ENDPOINT_TEST_STATUS

On Sat, Mar 21, 2020 at 11:21:39AM +0000, Lad Prabhakar wrote:
> PCI_ENDPOINT_TEST_STATUS is already defined in pci_endpoint_test.c along
> with the status bits, so this patch drops duplicate definition.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> This patch applies on top of pci/endpoint branch [1].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
>
> drivers/misc/pci_endpoint_test.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to pci/endpoint, thanks.

Lorenzo

> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index b536ca4b14ca..a1bb94902b5a 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -53,7 +53,6 @@
> #define STATUS_SRC_ADDR_INVALID BIT(7)
> #define STATUS_DST_ADDR_INVALID BIT(8)
>
> -#define PCI_ENDPOINT_TEST_STATUS 0x8
> #define PCI_ENDPOINT_TEST_LOWER_SRC_ADDR 0x0c
> #define PCI_ENDPOINT_TEST_UPPER_SRC_ADDR 0x10
>
> --
> 2.20.1
>