2020-03-23 05:36:36

by Yan Yankovskyi

[permalink] [raw]
Subject: [Xen-devel] [PATCH 2/2] evtchn: Change evtchn port type to evtchn_port_t

struct evtchn_set_priority uses uint32_t type for event channel port.
Replace the type with evtchn_port_t. Such change is also done in Linux.

Signed-off-by: Yan Yankovskyi <[email protected]>
---
xen/include/public/event_channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/event_channel.h b/xen/include/public/event_channel.h
index 44c549dd6b..cfb7929fef 100644
--- a/xen/include/public/event_channel.h
+++ b/xen/include/public/event_channel.h
@@ -307,7 +307,7 @@ typedef struct evtchn_expand_array evtchn_expand_array_t;
*/
struct evtchn_set_priority {
/* IN parameters. */
- uint32_t port;
+ evtchn_port_t port;
uint32_t priority;
};
typedef struct evtchn_set_priority evtchn_set_priority_t;
--
2.17.1


2020-03-23 07:51:27

by Jan Beulich

[permalink] [raw]
Subject: Re: [PATCH 2/2] evtchn: Change evtchn port type to evtchn_port_t

On 23.03.2020 06:35, Yan Yankovskyi wrote:
> struct evtchn_set_priority uses uint32_t type for event channel port.
> Replace the type with evtchn_port_t. Such change is also done in Linux.
>
> Signed-off-by: Yan Yankovskyi <[email protected]>

Reviewed-by: Jan Beulich <[email protected]>

As a general remark, the order of changes would better be the other way
around: The canonical header in the Xen repo be adjusted first, and the
change then propagated to repos carrying clones.

Thanks, Jan