2020-03-25 09:54:16

by Geert Uytterhoeven

Subject: [PATCH] h8300: dts: Fix /chosen:stdout-path

arch/h8300/boot/dts/h8s_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string
arch/h8300/boot/dts/h8300h_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string

Drop the angle brackets to fix this.

A similar fix was already applied to arch/h8300/boot/dts/edosk2674.dts
in commit 780ffcd51cb28717 ("h8300: register address fix").

Fixes: 38d6bded13084d50 ("h8300: devicetree source")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
arch/h8300/boot/dts/h8300h_sim.dts | 2 +-
arch/h8300/boot/dts/h8s_sim.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/h8300/boot/dts/h8300h_sim.dts b/arch/h8300/boot/dts/h8300h_sim.dts
index 595398b9d0180a80..e1d4d9b7f6b40c04 100644
--- a/arch/h8300/boot/dts/h8300h_sim.dts
+++ b/arch/h8300/boot/dts/h8300h_sim.dts
@@ -8,7 +8,7 @@

chosen {
bootargs = "earlyprintk=h8300-sim";
- stdout-path = <&sci0>;
+ stdout-path = &sci0;
};
aliases {
serial0 = &sci0;
diff --git a/arch/h8300/boot/dts/h8s_sim.dts b/arch/h8300/boot/dts/h8s_sim.dts
index 932cc3c5a81bcdd2..4848e40e607ecc1d 100644
--- a/arch/h8300/boot/dts/h8s_sim.dts
+++ b/arch/h8300/boot/dts/h8s_sim.dts
@@ -8,7 +8,7 @@

chosen {
bootargs = "earlyprintk=h8300-sim";
- stdout-path = <&sci0>;
+ stdout-path = &sci0;
};
aliases {
serial0 = &sci0;
--
2.17.1

2020-06-03 05:50:29

by Masahiro Yamada

Subject: Re: [PATCH] h8300: dts: Fix /chosen:stdout-path

On Wed, Mar 25, 2020 at 6:53 PM Geert Uytterhoeven
<[email protected]> wrote:
>
> arch/h8300/boot/dts/h8s_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string
> arch/h8300/boot/dts/h8300h_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string
>
> Drop the angle brackets to fix this.
>
> A similar fix was already applied to arch/h8300/boot/dts/edosk2674.dts
> in commit 780ffcd51cb28717 ("h8300: register address fix").
>
> Fixes: 38d6bded13084d50 ("h8300: devicetree source")
> Signed-off-by: Geert Uytterhoeven <[email protected]>


Reviewed-by: Masahiro Yamada <[email protected]>


Unfortunately, h8300 maintainer is not responding...

How to get this in?

Perhaps, Rob can pick this up?


Thanks.






> ---
> arch/h8300/boot/dts/h8300h_sim.dts | 2 +-
> arch/h8300/boot/dts/h8s_sim.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/h8300/boot/dts/h8300h_sim.dts b/arch/h8300/boot/dts/h8300h_sim.dts
> index 595398b9d0180a80..e1d4d9b7f6b40c04 100644
> --- a/arch/h8300/boot/dts/h8300h_sim.dts
> +++ b/arch/h8300/boot/dts/h8300h_sim.dts
> @@ -8,7 +8,7 @@
>
> chosen {
> bootargs = "earlyprintk=h8300-sim";
> - stdout-path = <&sci0>;
> + stdout-path = &sci0;
> };
> aliases {
> serial0 = &sci0;
> diff --git a/arch/h8300/boot/dts/h8s_sim.dts b/arch/h8300/boot/dts/h8s_sim.dts
> index 932cc3c5a81bcdd2..4848e40e607ecc1d 100644
> --- a/arch/h8300/boot/dts/h8s_sim.dts
> +++ b/arch/h8300/boot/dts/h8s_sim.dts
> @@ -8,7 +8,7 @@
>
> chosen {
> bootargs = "earlyprintk=h8300-sim";
> - stdout-path = <&sci0>;
> + stdout-path = &sci0;
> };
> aliases {
> serial0 = &sci0;
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada