2020-03-25 11:09:53

by Guido Günther

Subject: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

This value indicates when userspace should consider an object
near to the sensor/device.

Signed-off-by: Guido Günther <[email protected]>
---
.../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
index 21ef2eb7a205..ac9e3bb6a505 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
@@ -25,6 +25,13 @@ properties:
reg:
maxItems: 1

+ near-level:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Raw proximity values equal or above this level should be
+ considered 'near' to the device (an object is near to the
+ sensor).
+
required:
- compatible
- reg
@@ -40,6 +47,7 @@ examples:
light-sensor@51 {
compatible = "vishay,vcnl4200";
reg = <0x51>;
+ near-level = <220>;
};
};
...
--
2.23.0

2020-03-29 09:26:04

by Jonathan Cameron

Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

On Wed, 25 Mar 2020 12:09:06 +0100
Guido Günther <[email protected]> wrote:

> This value indicates when userspace should consider an object
> near to the sensor/device.
>
> Signed-off-by: Guido Günther <[email protected]>

I'm fine with this. Note for Rob or other DT people.

This is a new generic binding hence no vendor prefix.

I will ideally want review of both the dt patches though
before applying. As we've missed the merge window anyway
there is no particular rush.

Thanks,

Jonathan

> ---
> .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 21ef2eb7a205..ac9e3bb6a505 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -25,6 +25,13 @@ properties:
> reg:
> maxItems: 1
>
> + near-level:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Raw proximity values equal or above this level should be
> + considered 'near' to the device (an object is near to the
> + sensor).
> +
> required:
> - compatible
> - reg
> @@ -40,6 +47,7 @@ examples:
> light-sensor@51 {
> compatible = "vishay,vcnl4200";
> reg = <0x51>;
> + near-level = <220>;
> };
> };
> ...

2020-03-31 21:45:54

by Rob Herring (Arm)

Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> On Wed, 25 Mar 2020 12:09:06 +0100
> Guido G?nther <[email protected]> wrote:
>
> > This value indicates when userspace should consider an object
> > near to the sensor/device.
> >
> > Signed-off-by: Guido G?nther <[email protected]>
>
> I'm fine with this. Note for Rob or other DT people.
>
> This is a new generic binding hence no vendor prefix.

Then document in a common place.

>
> I will ideally want review of both the dt patches though
> before applying. As we've missed the merge window anyway
> there is no particular rush.
>
> Thanks,
>
> Jonathan
>
> > ---
> > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > index 21ef2eb7a205..ac9e3bb6a505 100644
> > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > @@ -25,6 +25,13 @@ properties:
> > reg:
> > maxItems: 1
> >
> > + near-level:

Perhaps proximity-near-level instead.

> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + Raw proximity values equal or above this level should be
> > + considered 'near' to the device (an object is near to the
> > + sensor).
> > +
> > required:
> > - compatible
> > - reg
> > @@ -40,6 +47,7 @@ examples:
> > light-sensor@51 {
> > compatible = "vishay,vcnl4200";
> > reg = <0x51>;
> > + near-level = <220>;
> > };
> > };
> > ...
>

2020-04-04 15:02:51

by Jonathan Cameron

Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

On Tue, 31 Mar 2020 15:45:17 -0600
Rob Herring <[email protected]> wrote:

> On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> > On Wed, 25 Mar 2020 12:09:06 +0100
> > Guido Günther <[email protected]> wrote:
> >
> > > This value indicates when userspace should consider an object
> > > near to the sensor/device.
> > >
> > > Signed-off-by: Guido Günther <[email protected]>
> >
> > I'm fine with this. Note for Rob or other DT people.
> >
> > This is a new generic binding hence no vendor prefix.
>
> Then document in a common place.

Ok.

I guess we need to create a proximity specific binding file.

Documentation/devicetree/bindings/iio/proximity.yaml

Guido, could you do a v4 adding such a file. For now I think
this is pretty much all that is proximity specific.

At somepoint we should convert the subsystem wide iio-bindings.txt
but not today!

Thanks,

Jonathan

>
> >
> > I will ideally want review of both the dt patches though
> > before applying. As we've missed the merge window anyway
> > there is no particular rush.
> >
> > Thanks,
> >
> > Jonathan
> >
> > > ---
> > > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > @@ -25,6 +25,13 @@ properties:
> > > reg:
> > > maxItems: 1
> > >
> > > + near-level:
>
> Perhaps proximity-near-level instead.

Makes sense.

>
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description:
> > > + Raw proximity values equal or above this level should be
> > > + considered 'near' to the device (an object is near to the
> > > + sensor).
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > @@ -40,6 +47,7 @@ examples:
> > > light-sensor@51 {
> > > compatible = "vishay,vcnl4200";
> > > reg = <0x51>;
> > > + near-level = <220>;
> > > };
> > > };
> > > ...
> >

2020-04-04 17:47:20

by Guido Günther

Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

Hi,
On Sat, Apr 04, 2020 at 04:01:27PM +0100, Jonathan Cameron wrote:
> On Tue, 31 Mar 2020 15:45:17 -0600
> Rob Herring <[email protected]> wrote:
>
> > On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> > > On Wed, 25 Mar 2020 12:09:06 +0100
> > > Guido G?nther <[email protected]> wrote:
> > >
> > > > This value indicates when userspace should consider an object
> > > > near to the sensor/device.
> > > >
> > > > Signed-off-by: Guido G?nther <[email protected]>
> > >
> > > I'm fine with this. Note for Rob or other DT people.
> > >
> > > This is a new generic binding hence no vendor prefix.
> >
> > Then document in a common place.
>
> Ok.
>
> I guess we need to create a proximity specific binding file.
>
> Documentation/devicetree/bindings/iio/proximity.yaml
>
> Guido, could you do a v4 adding such a file. For now I think
> this is pretty much all that is proximity specific.

I did a Documentation/devicetree/bindings/iio/common.yaml:

https://source.puri.sm/guido.gunther/linux-imx8/commit/8b91f0b7fa76ca4b2f3cdc251411829f71f8d810

so we can add new properties there and move iio-bindings.txt over.

Does that work as well? If so I'll send out a v4.
Cheers,
-- Guido


>
> At somepoint we should convert the subsystem wide iio-bindings.txt
> but not today!
>
> Thanks,
>
> Jonathan
>
> >
> > >
> > > I will ideally want review of both the dt patches though
> > > before applying. As we've missed the merge window anyway
> > > there is no particular rush.
> > >
> > > Thanks,
> > >
> > > Jonathan
> > >
> > > > ---
> > > > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > @@ -25,6 +25,13 @@ properties:
> > > > reg:
> > > > maxItems: 1
> > > >
> > > > + near-level:
> >
> > Perhaps proximity-near-level instead.
>
> Makes sense.
>
> >
> > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > + description:
> > > > + Raw proximity values equal or above this level should be
> > > > + considered 'near' to the device (an object is near to the
> > > > + sensor).
> > > > +
> > > > required:
> > > > - compatible
> > > > - reg
> > > > @@ -40,6 +47,7 @@ examples:
> > > > light-sensor@51 {
> > > > compatible = "vishay,vcnl4200";
> > > > reg = <0x51>;
> > > > + near-level = <220>;
> > > > };
> > > > };
> > > > ...
> > >
>

2020-04-05 09:46:23

by Jonathan Cameron

Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level

On Sat, 4 Apr 2020 19:45:21 +0200
Guido Günther <[email protected]> wrote:

> Hi,
> On Sat, Apr 04, 2020 at 04:01:27PM +0100, Jonathan Cameron wrote:
> > On Tue, 31 Mar 2020 15:45:17 -0600
> > Rob Herring <[email protected]> wrote:
> >
> > > On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:
> > > > On Wed, 25 Mar 2020 12:09:06 +0100
> > > > Guido Günther <[email protected]> wrote:
> > > >
> > > > > This value indicates when userspace should consider an object
> > > > > near to the sensor/device.
> > > > >
> > > > > Signed-off-by: Guido Günther <[email protected]>
> > > >
> > > > I'm fine with this. Note for Rob or other DT people.
> > > >
> > > > This is a new generic binding hence no vendor prefix.
> > >
> > > Then document in a common place.
> >
> > Ok.
> >
> > I guess we need to create a proximity specific binding file.
> >
> > Documentation/devicetree/bindings/iio/proximity.yaml
> >
> > Guido, could you do a v4 adding such a file. For now I think
> > this is pretty much all that is proximity specific.
>
> I did a Documentation/devicetree/bindings/iio/common.yaml:
>
> https://source.puri.sm/guido.gunther/linux-imx8/commit/8b91f0b7fa76ca4b2f3cdc251411829f71f8d810
>
> so we can add new properties there and move iio-bindings.txt over.
>
> Does that work as well? If so I'll send out a v4.

I can't find any real precedence for naming of such files.
So I guess this is still evolving. Send it out and we'll see what Rob thinks.

Jonathan


> Cheers,
> -- Guido
>
>
> >
> > At somepoint we should convert the subsystem wide iio-bindings.txt
> > but not today!
> >
> > Thanks,
> >
> > Jonathan
> >
> > >
> > > >
> > > > I will ideally want review of both the dt patches though
> > > > before applying. As we've missed the merge window anyway
> > > > there is no particular rush.
> > > >
> > > > Thanks,
> > > >
> > > > Jonathan
> > > >
> > > > > ---
> > > > > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 8 ++++++++
> > > > > 1 file changed, 8 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > @@ -25,6 +25,13 @@ properties:
> > > > > reg:
> > > > > maxItems: 1
> > > > >
> > > > > + near-level:
> > >
> > > Perhaps proximity-near-level instead.
> >
> > Makes sense.
> >
> > >
> > > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > > + description:
> > > > > + Raw proximity values equal or above this level should be
> > > > > + considered 'near' to the device (an object is near to the
> > > > > + sensor).
> > > > > +
> > > > > required:
> > > > > - compatible
> > > > > - reg
> > > > > @@ -40,6 +47,7 @@ examples:
> > > > > light-sensor@51 {
> > > > > compatible = "vishay,vcnl4200";
> > > > > reg = <0x51>;
> > > > > + near-level = <220>;
> > > > > };
> > > > > };
> > > > > ...
> > > >
> >