2020-04-05 02:51:56

by Stephen Boyd

Subject: [PATCH 1/9] ARM: Remove redundant COMMON_CLK selects

The mulitplatform config already selects COMMON_CLK, so selecting it
again is not useful. Remove these selects from ARM platforms that are
part of the multiplatform build.

Cc: "Andreas Färber" <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Russell King <[email protected]>
Cc: Alexander Shiyan <[email protected]>
Cc: Lubomir Rintel <[email protected]>
Cc: <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
arch/arm/mach-actions/Kconfig | 1 -
arch/arm/mach-clps711x/Kconfig | 1 -
arch/arm/mach-mmp/Kconfig | 1 -
3 files changed, 3 deletions(-)

diff --git a/arch/arm/mach-actions/Kconfig b/arch/arm/mach-actions/Kconfig
index b5e0ac965ec0..00fb4babccdd 100644
--- a/arch/arm/mach-actions/Kconfig
+++ b/arch/arm/mach-actions/Kconfig
@@ -7,7 +7,6 @@ menuconfig ARCH_ACTIONS
select ARM_GLOBAL_TIMER
select CACHE_L2X0
select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
- select COMMON_CLK
select GENERIC_IRQ_CHIP
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
diff --git a/arch/arm/mach-clps711x/Kconfig b/arch/arm/mach-clps711x/Kconfig
index fc9188b54dd6..ba497a2032e9 100644
--- a/arch/arm/mach-clps711x/Kconfig
+++ b/arch/arm/mach-clps711x/Kconfig
@@ -5,7 +5,6 @@ menuconfig ARCH_CLPS711X
select AUTO_ZRELADDR
select TIMER_OF
select CLPS711X_TIMER
- select COMMON_CLK
select CPU_ARM720T
select GENERIC_CLOCKEVENTS
select GPIOLIB
diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index b58a03b18bde..6fe1550f43ec 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -110,7 +110,6 @@ config MACH_MMP_DT
depends on ARCH_MULTI_V5
select PINCTRL
select PINCTRL_SINGLE
- select COMMON_CLK
select ARCH_HAS_RESET_CONTROLLER
select CPU_MOHAWK
help
--
Sent by a computer, using git, on the internet

2020-04-05 06:22:51

by Manivannan Sadhasivam

Subject: Re: [PATCH 1/9] ARM: Remove redundant COMMON_CLK selects

On Sat, Apr 04, 2020 at 07:51:15PM -0700, Stephen Boyd wrote:
> The mulitplatform config already selects COMMON_CLK, so selecting it
> again is not useful. Remove these selects from ARM platforms that are
> part of the multiplatform build.
>
> Cc: "Andreas F?rber" <[email protected]>
> Cc: Manivannan Sadhasivam <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Alexander Shiyan <[email protected]>
> Cc: Lubomir Rintel <[email protected]>
> Cc: <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

For Actions,

Acked-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> arch/arm/mach-actions/Kconfig | 1 -
> arch/arm/mach-clps711x/Kconfig | 1 -
> arch/arm/mach-mmp/Kconfig | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/mach-actions/Kconfig b/arch/arm/mach-actions/Kconfig
> index b5e0ac965ec0..00fb4babccdd 100644
> --- a/arch/arm/mach-actions/Kconfig
> +++ b/arch/arm/mach-actions/Kconfig
> @@ -7,7 +7,6 @@ menuconfig ARCH_ACTIONS
> select ARM_GLOBAL_TIMER
> select CACHE_L2X0
> select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> - select COMMON_CLK
> select GENERIC_IRQ_CHIP
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> diff --git a/arch/arm/mach-clps711x/Kconfig b/arch/arm/mach-clps711x/Kconfig
> index fc9188b54dd6..ba497a2032e9 100644
> --- a/arch/arm/mach-clps711x/Kconfig
> +++ b/arch/arm/mach-clps711x/Kconfig
> @@ -5,7 +5,6 @@ menuconfig ARCH_CLPS711X
> select AUTO_ZRELADDR
> select TIMER_OF
> select CLPS711X_TIMER
> - select COMMON_CLK
> select CPU_ARM720T
> select GENERIC_CLOCKEVENTS
> select GPIOLIB
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index b58a03b18bde..6fe1550f43ec 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -110,7 +110,6 @@ config MACH_MMP_DT
> depends on ARCH_MULTI_V5
> select PINCTRL
> select PINCTRL_SINGLE
> - select COMMON_CLK
> select ARCH_HAS_RESET_CONTROLLER
> select CPU_MOHAWK
> help
> --
> Sent by a computer, using git, on the internet
>

2020-04-06 11:04:03

by Andreas Färber

Subject: Re: [PATCH 1/9] ARM: Remove redundant COMMON_CLK selects

Am 05.04.20 um 04:51 schrieb Stephen Boyd:
> The mulitplatform config already selects COMMON_CLK, so selecting it
> again is not useful. Remove these selects from ARM platforms that are
> part of the multiplatform build.
>
> Cc: "Andreas Färber" <[email protected]>
> Cc: Manivannan Sadhasivam <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Alexander Shiyan <[email protected]>
> Cc: Lubomir Rintel <[email protected]>
> Cc: <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> arch/arm/mach-actions/Kconfig | 1 -
> arch/arm/mach-clps711x/Kconfig | 1 -
> arch/arm/mach-mmp/Kconfig | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/arch/arm/mach-actions/Kconfig b/arch/arm/mach-actions/Kconfig
> index b5e0ac965ec0..00fb4babccdd 100644
> --- a/arch/arm/mach-actions/Kconfig
> +++ b/arch/arm/mach-actions/Kconfig
> @@ -7,7 +7,6 @@ menuconfig ARCH_ACTIONS
> select ARM_GLOBAL_TIMER
> select CACHE_L2X0
> select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> - select COMMON_CLK
> select GENERIC_IRQ_CHIP
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP

Reviewed-by: Andreas Färber <[email protected]> (Actions)

New targets such as Realtek or Sunplus don't select it anymore, but it
seems we didn't clean up all the old ones yet.

Thanks,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)