2020-04-02 19:20:50

by Prarit Bhargava

Subject: [PATCH] tools/power/x86/intel-speed-select: Fix CLX-N package information output

On CLX-N the perf-profile output is missing the package, die, and cpu
output. On CLX-N the pkg_dev struct will never be evaluated by the core
code so pkg_dev.processed is always 0 and the package, die, and cpu
information is never output.

Set the pkg_dev.processed flag to 1 for CLX-N processors.

Signed-off-by: Prarit Bhargava <[email protected]>
Cc: [email protected]
Cc: Srinivas Pandruvada <[email protected]>
Cc: [email protected]
---
tools/power/x86/intel-speed-select/isst-config.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
index d1ac57be0cbd..2e64b9b6eb2e 100644
--- a/tools/power/x86/intel-speed-select/isst-config.c
+++ b/tools/power/x86/intel-speed-select/isst-config.c
@@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2,

ctdp_level = &clx_n_pkg_dev.ctdp_level[0];
pbf_info = &ctdp_level->pbf_info;
+ clx_n_pkg_dev.processed = 1;
isst_ctdp_display_information(cpu, outf, tdp_level, &clx_n_pkg_dev);
free_cpu_set(ctdp_level->core_cpumask);
free_cpu_set(pbf_info->core_cpumask);
--
2.18.2

2020-04-16 00:21:17

by Andy Shevchenko

Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix CLX-N package information output

On Thu, Apr 02, 2020 at 02:07:32PM -0400, Prarit Bhargava wrote:
> On CLX-N the perf-profile output is missing the package, die, and cpu
> output. On CLX-N the pkg_dev struct will never be evaluated by the core
> code so pkg_dev.processed is always 0 and the package, die, and cpu
> information is never output.
>
> Set the pkg_dev.processed flag to 1 for CLX-N processors.

I will accept this with PR from Srinivas whenever he sends one to public mailing list.

> Signed-off-by: Prarit Bhargava <[email protected]>
> Cc: [email protected]
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: [email protected]
> ---
> tools/power/x86/intel-speed-select/isst-config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
> index d1ac57be0cbd..2e64b9b6eb2e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2,
>
> ctdp_level = &clx_n_pkg_dev.ctdp_level[0];
> pbf_info = &ctdp_level->pbf_info;
> + clx_n_pkg_dev.processed = 1;
> isst_ctdp_display_information(cpu, outf, tdp_level, &clx_n_pkg_dev);
> free_cpu_set(ctdp_level->core_cpumask);
> free_cpu_set(pbf_info->core_cpumask);
> --
> 2.18.2
>

--
With Best Regards,
Andy Shevchenko

2020-04-16 00:23:48

by Srinivas Pandruvada

Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix CLX-N package information output

On Wed, 2020-04-15 at 19:10 +0300, Andy Shevchenko wrote:
> On Thu, Apr 02, 2020 at 02:07:32PM -0400, Prarit Bhargava wrote:
> > On CLX-N the perf-profile output is missing the package, die, and
> > cpu
> > output. On CLX-N the pkg_dev struct will never be evaluated by the
> > core
> > code so pkg_dev.processed is always 0 and the package, die, and cpu
> > information is never output.
> >
> > Set the pkg_dev.processed flag to 1 for CLX-N processors.
>
Sorry Prarit. It took long to respond. The patch is fine. I am applying
to my tree.

-Srinivas

> I will accept this with PR from Srinivas whenever he sends one to
> public mailing list.
>
> > Signed-off-by: Prarit Bhargava <[email protected]>
> > Cc: [email protected]
> > Cc: Srinivas Pandruvada <[email protected]>
> > Cc: [email protected]
> > ---
> > tools/power/x86/intel-speed-select/isst-config.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> > b/tools/power/x86/intel-speed-select/isst-config.c
> > index d1ac57be0cbd..2e64b9b6eb2e 100644
> > --- a/tools/power/x86/intel-speed-select/isst-config.c
> > +++ b/tools/power/x86/intel-speed-select/isst-config.c
> > @@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int
> > cpu, void *arg1, void *arg2,
> >
> > ctdp_level = &clx_n_pkg_dev.ctdp_level[0];
> > pbf_info = &ctdp_level->pbf_info;
> > + clx_n_pkg_dev.processed = 1;
> > isst_ctdp_display_information(cpu, outf, tdp_level,
> > &clx_n_pkg_dev);
> > free_cpu_set(ctdp_level->core_cpumask);
> > free_cpu_set(pbf_info->core_cpumask);
> > --
> > 2.18.2
> >