2020-04-18 07:56:44

by Jason Yan

Subject: [PATCH] arm64: entry: remove unneeded semicolon in el1_sync_handler()

Fix the following coccicheck warning:

arch/arm64/kernel/entry-common.c:97:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
arch/arm64/kernel/entry-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
index c839b5bf1904..bed09a866c2f 100644
--- a/arch/arm64/kernel/entry-common.c
+++ b/arch/arm64/kernel/entry-common.c
@@ -94,7 +94,7 @@ asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
break;
default:
el1_inv(regs, esr);
- };
+ }
}
NOKPROBE_SYMBOL(el1_sync_handler);

--
2.21.1

2020-04-20 10:20:51

by Mark Rutland

Subject: Re: [PATCH] arm64: entry: remove unneeded semicolon in el1_sync_handler()

On Sat, Apr 18, 2020 at 04:19:09PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/arm64/kernel/entry-common.c:97:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Acked-by: Mark Rutland <[email protected]>

Mark.

> ---
> arch/arm64/kernel/entry-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
> index c839b5bf1904..bed09a866c2f 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -94,7 +94,7 @@ asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
> break;
> default:
> el1_inv(regs, esr);
> - };
> + }
> }
> NOKPROBE_SYMBOL(el1_sync_handler);
>
> --
> 2.21.1
>

2020-04-28 14:52:10

by Will Deacon

Subject: Re: [PATCH] arm64: entry: remove unneeded semicolon in el1_sync_handler()

On Sat, 18 Apr 2020 16:19:09 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/arm64/kernel/entry-common.c:97:2-3: Unneeded semicolon

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: entry: remove unneeded semicolon in el1_sync_handler()
https://git.kernel.org/arm64/c/0dd2334fd5b9

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev