2020-04-18 08:51:50

by Tang Bin

Subject: [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()

In the function bcm_sysport_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant message
here.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index af7ce5c54..c99e5a3fa 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2475,7 +2475,6 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->wol_irq = platform_get_irq(pdev, 1);
}
if (priv->irq0 <= 0 || (priv->irq1 <= 0 && !priv->is_lite)) {
- dev_err(&pdev->dev, "invalid interrupts\n");
ret = -EINVAL;
goto err_free_netdev;
}
--
2.20.1.windows.1

2020-04-18 15:54:58

by Florian Fainelli

Subject: Re: [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()

On 4/18/2020 1:51 AM, Tang Bin wrote:
> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-04-20 18:09:28

by David Miller

Subject: Re: [PATCH] net: systemport: Omit superfluous error message in bcm_sysport_probe()

From: Tang Bin <[email protected]>
Date: Sat, 18 Apr 2020 16:51:06 +0800

> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <[email protected]>

Applied.