2020-04-18 10:03:24

by Tang Bin

Subject: [PATCH] drm/etnaviv: Omit superfluous error message in etnaviv_gpu_platform_probe()

In the function etnaviv_gpu_platform_probe(), when get irq failed,
the function platform_get_irq() logs an error message, so remove
redundant message here.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index a31eeff2b..6dbe0c45b 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)

/* Get Interrupt: */
gpu->irq = platform_get_irq(pdev, 0);
- if (gpu->irq < 0) {
- dev_err(dev, "failed to get irq: %d\n", gpu->irq);
+ if (gpu->irq < 0)
return gpu->irq;
- }

err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
dev_name(gpu->dev), gpu);
--
2.20.1.windows.1

2020-04-20 15:21:39

by Christian Gmeiner

Subject: Re: [PATCH] drm/etnaviv: Omit superfluous error message in etnaviv_gpu_platform_probe()

Am Sa., 18. Apr. 2020 um 12:01 Uhr schrieb Tang Bin
<[email protected]>:
>
> In the function etnaviv_gpu_platform_probe(), when get irq failed,
> the function platform_get_irq() logs an error message, so remove
> redundant message here.
>
> Signed-off-by: Tang Bin <[email protected]>

Reviewed-by: Christian Gmeiner <[email protected]>

> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index a31eeff2b..6dbe0c45b 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
>
> /* Get Interrupt: */
> gpu->irq = platform_get_irq(pdev, 0);
> - if (gpu->irq < 0) {
> - dev_err(dev, "failed to get irq: %d\n", gpu->irq);
> + if (gpu->irq < 0)
> return gpu->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> dev_name(gpu->dev), gpu);
> --
> 2.20.1.windows.1
>
>
>


--
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy